avcodec/g723_1dec: fix invalid shift with negative sid_gain
authorMichael Niedermayer <michael@niedermayer.cc>
Sat, 26 Oct 2019 19:56:03 +0000 (21:56 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Tue, 29 Oct 2019 15:20:33 +0000 (16:20 +0100)
Fixes: left shift of negative value -1
Fixes: 18395/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G723_1_fuzzer-5710313034350592

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/g723_1dec.c

index a7bf528..f601d31 100644 (file)
@@ -677,7 +677,7 @@ static int estimate_sid_gain(G723_1_ChannelContext *p)
             if (p->sid_gain < 0) t = INT32_MIN;
             else                 t = INT32_MAX;
         } else
-            t = p->sid_gain << shift;
+            t = p->sid_gain * (1 << shift);
     } else if(shift < -31) {
         t = (p->sid_gain < 0) ? -1 : 0;
     }else