avcodec/wmalosslessdec: Fixes undefined overflow in dequantization in decode_subframe()
authorMichael Niedermayer <michael@niedermayer.cc>
Fri, 29 Nov 2019 21:45:07 +0000 (22:45 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Tue, 31 Dec 2019 17:43:50 +0000 (18:43 +0100)
Fixes: signed integer overflow: 47875596 * 45 cannot be represented in type 'int'
Fixes: 19082/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5687766512041984

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/wmalosslessdec.c

index d4dd0ed..d2f9d4a 100644 (file)
@@ -979,7 +979,7 @@ static int decode_subframe(WmallDecodeCtx *s)
         if (s->quant_stepsize != 1)
             for (i = 0; i < s->num_channels; i++)
                 for (j = 0; j < subframe_len; j++)
-                    s->channel_residues[i][j] *= s->quant_stepsize;
+                    s->channel_residues[i][j] *= (unsigned)s->quant_stepsize;
     }
 
     /* Write to proper output buffer depending on bit-depth */