avcodec/takdec: Fix integer overflow in decode_lpc()
authorMichael Niedermayer <michael@niedermayer.cc>
Fri, 22 Sep 2017 18:45:27 +0000 (20:45 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Sun, 24 Sep 2017 19:54:13 +0000 (21:54 +0200)
Fixes: runtime error: signed integer overflow: 16748560 + 2143729712 cannot be represented in type 'int'
Fixes: 3202/clusterfuzz-testcase-minimized-4988291642294272

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/takdec.c

index 9c253c1..0439a3a 100644 (file)
@@ -206,7 +206,7 @@ static void decode_lpc(int32_t *coeffs, int mode, int length)
         unsigned a1 = *coeffs++;
         for (i = 0; i < length - 1 >> 1; i++) {
             *coeffs   += a1;
-            coeffs[1] += *coeffs;
+            coeffs[1] += (unsigned)*coeffs;
             a1         = coeffs[1];
             coeffs    += 2;
         }