avcodec/takdec: Fix integer overflow in decorrelate()
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 25 Aug 2019 15:49:15 +0000 (17:49 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Wed, 11 Sep 2019 20:43:14 +0000 (22:43 +0200)
Fixes: signed integer overflow: -2424832 - 2145653689 cannot be represented in type 'int'
Fixes: 16138/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5643451346976768

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/takdec.c

index 0439a3a..4fb5825 100644 (file)
@@ -653,7 +653,7 @@ static int decorrelate(TAKDecContext *s, int c1, int c2, int length)
                          s->residues[i    ] * s->filter[0];
                 }
 
-                v = av_clip_intp2(v >> 10, 13) * (1 << dshift) - *p1;
+                v = av_clip_intp2(v >> 10, 13) * (1U << dshift) - *p1;
                 *p1++ = v;
             }