ffmpeg.git
18 months agoavcodec/pcm: Fix undefined shifts
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:01 +0000 (00:17 +0200)]
avcodec/pcm: Fix undefined shifts

Fixes the acodec-pcm-u16[lb]e FATE-tests.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
18 months agoavcodec/wavpackenc: Fix undefined shifts
Andreas Rheinhardt [Thu, 19 Sep 2019 22:16:58 +0000 (00:16 +0200)]
avcodec/wavpackenc: Fix undefined shifts

Fixes ticket #8161 and the acodec-wavpack FATE-test.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
18 months agolavc/qsv: add memory type message
Zhong Li [Thu, 19 Sep 2019 20:45:27 +0000 (04:45 +0800)]
lavc/qsv: add memory type message

Signed-off-by: Zhong Li <zhong.li@intel.com>
18 months agolavc/qsv: Fix MSDK initialization failure in system memory mode
Zhong Li [Thu, 19 Sep 2019 20:45:26 +0000 (04:45 +0800)]
lavc/qsv: Fix MSDK initialization failure in system memory mode

MSDK does not create internal acceleration device on Linux,
So MFXVideoCORE_SetHandle() is necessary.
It has been added for ff_qsv_init_session_device().
But missed for ff_qsv_init_internal_session() due to commit
1f26a23 overwrited commit db89f45

Fix #7030

Signed-off-by: Zhong Li <zhong.li@intel.com>
18 months agoavformat/utils: ensure that all packets in AVPacketList are reference counted
Andreas Rheinhardt [Thu, 26 Sep 2019 00:05:58 +0000 (02:05 +0200)]
avformat/utils: ensure that all packets in AVPacketList are reference counted

This is done so that its data is really owned by the packet.
This was already true for the current callers.

Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavfilter/x86/vf_eq: add SSE2 version
Ting Fu [Wed, 18 Sep 2019 07:05:35 +0000 (15:05 +0800)]
avfilter/x86/vf_eq: add SSE2 version

Signed-off-by: Ting Fu <ting.fu@intel.com>
18 months agoavfilter/x86/vf_eq: Change inline assembly into nasm code
Ting Fu [Wed, 18 Sep 2019 07:05:34 +0000 (15:05 +0800)]
avfilter/x86/vf_eq: Change inline assembly into nasm code

Signed-off-by: Ting Fu <ting.fu@intel.com>
18 months agocheckasm/vf_eq: add test for vf_eq
Ting Fu [Wed, 18 Sep 2019 07:05:33 +0000 (15:05 +0800)]
checkasm/vf_eq: add test for vf_eq

Signed-off-by: Ting Fu <ting.fu@intel.com>
Signed-off-by: Ruiling Song <ruiling.song@intel.com>
18 months agoavformat/utils: Move the reference to the packet list
Andreas Rheinhardt [Fri, 20 Sep 2019 20:39:10 +0000 (22:39 +0200)]
avformat/utils: Move the reference to the packet list

Up until now, ff_packet_list_put had a flaw: When it moved a packet to
the list (meaning, when it ought to move the reference to the packet
list instead of creating a new one via av_packet_ref), it did not reset
the original packet, confusing the ownership of the data in the packet.
This has been done because some callers of this function were not
compatible with resetting the packet.

This commit changes these callers and fixes this flaw. In order to
indicate that the ownership of the packet has moved to the packet list,
pointers to constant AVPackets are used whenever the target of the
pointer might already be owned by the packet list.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavformat/utils: unref packet on AVInputFormat.read_packet() failure
James Almer [Fri, 20 Sep 2019 20:39:09 +0000 (22:39 +0200)]
avformat/utils: unref packet on AVInputFormat.read_packet() failure

Demuxers may have allocated a packet before encountering an error and aborting.

Fixes ticket #8150

Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavformat/utils: Fix memleaks
Andreas Rheinhardt [Tue, 24 Sep 2019 16:31:44 +0000 (18:31 +0200)]
avformat/utils: Fix memleaks

ff_read_packet had potential memleaks:
1. If av_packet_make_refcounted fails, it means that the packet is not
refcounted, but it could nevertheless carry side data and therefore
needs to be unreferenced.
2. If putting a packet on a packet list fails, it wasn't unreferenced.

Furthermore, read_frame_internal leaked a packet's (side) data if a
context update was required and failed.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavformat/utils: Assert that stream_index is valid
Andreas Rheinhardt [Tue, 24 Sep 2019 16:31:43 +0000 (18:31 +0200)]
avformat/utils: Assert that stream_index is valid

There is currently an ordinary check for this (which would lead to a
memleak), but given that no demuxer should ever return a packet with an
invalid stream_index it is more appropriate for this to be an assert.

FATE passes with this change.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
18 months agolavf/mov: Fix timestamp rescale on sidx atom
Jun Li [Thu, 9 May 2019 09:07:56 +0000 (02:07 -0700)]
lavf/mov: Fix timestamp rescale on sidx atom

Fix #5090
Fix the timestamp rescale issue, from sidx timebase to
stream's timebase.

18 months agoRevert "lavc/tiff: correct the default value of YCbCrSubsampling to 2x2"
Carl Eugen Hoyos [Wed, 25 Sep 2019 22:34:44 +0000 (00:34 +0200)]
Revert "lavc/tiff: correct the default value of YCbCrSubsampling to 2x2"

This reverts commit eb5d0f18ff609ba2280cea4e2c6286d216c8756b.

Together with 89f464e9, it breaks decoding of tiff files like fate-suite/exif/image_small.tiff

18 months agoavcodec/dnxhdenc: return error if av_malloc failed
Limin Wang [Mon, 23 Sep 2019 03:36:18 +0000 (11:36 +0800)]
avcodec/dnxhdenc: return error if av_malloc failed

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavfilter/vf_zoompan: fix leaks
Paul B Mahol [Wed, 25 Sep 2019 19:39:49 +0000 (21:39 +0200)]
avfilter/vf_zoompan: fix leaks

18 months agoavfilter/vf_zoompan: forward status back from output to input
Paul B Mahol [Wed, 25 Sep 2019 19:37:26 +0000 (21:37 +0200)]
avfilter/vf_zoompan: forward status back from output to input

18 months agoavfilter/vf_stack: add slice threading
Paul B Mahol [Wed, 25 Sep 2019 17:02:57 +0000 (19:02 +0200)]
avfilter/vf_stack: add slice threading

18 months agoavfilter/vf_stack: simplify main processing path
Paul B Mahol [Wed, 25 Sep 2019 16:40:56 +0000 (18:40 +0200)]
avfilter/vf_stack: simplify main processing path

18 months agoavformat/sdsdec: fix undefined behaviour
Paul B Mahol [Wed, 25 Sep 2019 16:01:09 +0000 (18:01 +0200)]
avformat/sdsdec: fix undefined behaviour

Fixes #8163, #8164, #8165.

18 months agoavformat/aiffdec: fix signed integer overflow
Paul B Mahol [Wed, 25 Sep 2019 15:36:52 +0000 (17:36 +0200)]
avformat/aiffdec: fix signed integer overflow

Fixes #8151

18 months agoavcodec/decode: Check max_samples in get_buffer_internal()
Michael Niedermayer [Wed, 25 Sep 2019 14:18:32 +0000 (16:18 +0200)]
avcodec/decode: Check max_samples in get_buffer_internal()

This checks max_samples at the same level as max_pixels

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agotools/target_dec_fuzzer: Set max_samples
Michael Niedermayer [Mon, 2 Sep 2019 22:04:00 +0000 (00:04 +0200)]
tools/target_dec_fuzzer: Set max_samples

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec: add max_samples
Michael Niedermayer [Mon, 2 Sep 2019 21:17:57 +0000 (23:17 +0200)]
avcodec: add max_samples

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavfilter/Makefile: fix case for sierpinski
Paul B Mahol [Wed, 25 Sep 2019 12:15:55 +0000 (14:15 +0200)]
avfilter/Makefile: fix case for sierpinski

18 months agoavfilter: add sierpinski video source
Paul B Mahol [Mon, 12 Aug 2019 07:20:08 +0000 (09:20 +0200)]
avfilter: add sierpinski video source

18 months agoavfilter/vf_premultiply: forward status back from output to all input links
Paul B Mahol [Wed, 25 Sep 2019 11:02:39 +0000 (13:02 +0200)]
avfilter/vf_premultiply: forward status back from output to all input links

18 months agoavfilter/vf_fieldmatch: forward status back from output to all input links
Paul B Mahol [Wed, 25 Sep 2019 10:55:43 +0000 (12:55 +0200)]
avfilter/vf_fieldmatch: forward status back from output to all input links

Fixes #8199.

18 months agoavfilter/vf_fieldmatch: fix more leaks
Paul B Mahol [Wed, 25 Sep 2019 10:35:33 +0000 (12:35 +0200)]
avfilter/vf_fieldmatch: fix more leaks

18 months agoavfilter/vf_v360: add sinusoidal format
Paul B Mahol [Wed, 25 Sep 2019 10:01:54 +0000 (12:01 +0200)]
avfilter/vf_v360: add sinusoidal format

18 months agolavc/tiff: correct the default value of YCbCrSubsampling to 2x2
Pavel Skakov [Wed, 25 Sep 2019 08:47:46 +0000 (10:47 +0200)]
lavc/tiff: correct the default value of YCbCrSubsampling to 2x2

18 months agolavf/4xm: fix memory leak in error handing path
Jun Zhao [Mon, 23 Sep 2019 02:50:21 +0000 (10:50 +0800)]
lavf/4xm: fix memory leak in error handing path

need to free the header in error path.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
18 months agolibavcodec/libx265: add a flag to output ROI warnings only once.
Guo, Yejun [Mon, 23 Sep 2019 02:02:35 +0000 (10:02 +0800)]
libavcodec/libx265: add a flag to output ROI warnings only once.

Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
18 months agolibavcodec/libx264: add a flag to output ROI warnings only once.
Guo, Yejun [Mon, 23 Sep 2019 02:02:34 +0000 (10:02 +0800)]
libavcodec/libx264: add a flag to output ROI warnings only once.

Signed-off-by: Guo, Yejun <yejun.guo@intel.com>
18 months agoavcodec/utils: Optimize ff_color_frame() using memcpy()
Michael Niedermayer [Mon, 24 Dec 2018 00:14:51 +0000 (01:14 +0100)]
avcodec/utils: Optimize ff_color_frame() using memcpy()

4650975 -> 4493240 dezicycles

This optimizes lines 2 and later. Line 1 still uses av_memcpy_backptr()
This change originally fixed ossfuzz 10790 but this is now fixed by other
optimizations already

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/aacdec: Check if we run out of input in read_stream_mux_config()
Michael Niedermayer [Sun, 8 Sep 2019 19:08:31 +0000 (21:08 +0200)]
avcodec/aacdec: Check if we run out of input in read_stream_mux_config()

Fixes: Infinite loop
Fixes: 16920/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5653421289373696

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/h264_slice: clear frame only on gaps when it is not otherwise initilaized
Michael Niedermayer [Sun, 8 Sep 2019 17:27:26 +0000 (19:27 +0200)]
avcodec/h264_slice: clear frame only on gaps when it is not otherwise initilaized

Fixes: Timeout (53sec -> 31sec)
Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/utils: Use av_memcpy_backptr() in ff_color_frame()
Michael Niedermayer [Sun, 8 Sep 2019 15:25:07 +0000 (17:25 +0200)]
avcodec/utils: Use av_memcpy_backptr() in ff_color_frame()

Fixes: Timeout (191sec -> 53sec)
Fixes: 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864
Fixes: 10709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5630617975259136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/smacker: Fix integer overflow in signed int multiply in SMK_BLK_FILL
Michael Niedermayer [Fri, 6 Sep 2019 08:55:26 +0000 (10:55 +0200)]
avcodec/smacker: Fix integer overflow in signed int multiply in SMK_BLK_FILL

Fixes: signed integer overflow: 238 * 16843009 cannot be represented in type 'int'
Fixes: 16958/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5193905355620352

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/alac: Fix invalid shifts in 20/24 bps
Michael Niedermayer [Fri, 6 Sep 2019 08:46:38 +0000 (10:46 +0200)]
avcodec/alac: Fix invalid shifts in 20/24 bps

Fixes: left shift of negative value -256
Fixes: 16892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-4880802642395136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()
Michael Niedermayer [Fri, 6 Sep 2019 08:36:43 +0000 (10:36 +0200)]
avcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()

Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int'
Fixes: 16786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5632818851348480

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/utils: Do not assume duration is non negative in compute_pkt_fields()
Michael Niedermayer [Thu, 5 Sep 2019 21:06:21 +0000 (23:06 +0200)]
avformat/utils: Do not assume duration is non negative in compute_pkt_fields()

Several subtitle demuxers set negative durations

Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be represented in type 'long'
Fixes: 16925/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5766519790764032

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/ffwavesynth: Fix integer overflow in timestamps
Michael Niedermayer [Thu, 5 Sep 2019 18:47:04 +0000 (20:47 +0200)]
avcodec/ffwavesynth: Fix integer overflow in timestamps

Fixes: signed integer overflow: 9223371075321077760 * 2 cannot be represented in type 'long'
Fixes: 16447/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5698937431785472

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/vividas: Test size and packet numbers a bit more
Michael Niedermayer [Wed, 4 Sep 2019 14:30:00 +0000 (16:30 +0200)]
avformat/vividas: Test size and packet numbers a bit more

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/vividas: Check n_sb_blocks against input space
Michael Niedermayer [Wed, 4 Sep 2019 14:18:35 +0000 (16:18 +0200)]
avformat/vividas: Check n_sb_blocks against input space

Fixes: OOM
Fixes: 16726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5719320750981120

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/aacdec_fixed: Add FF_CODEC_CAP_INIT_CLEANUP
Michael Niedermayer [Wed, 4 Sep 2019 13:19:46 +0000 (15:19 +0200)]
avcodec/aacdec_fixed: Add FF_CODEC_CAP_INIT_CLEANUP

Fixes: memleaks
Fixes: 16788/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5649873898045440

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agotools/target_dec_fuzzer: consider potential padding/edge in pixel threshold
Michael Niedermayer [Wed, 4 Sep 2019 12:24:48 +0000 (14:24 +0200)]
tools/target_dec_fuzzer: consider potential padding/edge in pixel threshold

Fixes: Timeout (73sec ->30ms)
Fixes: 16921/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5689384594046976

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agolibavcodec/mpeg12dec: Check input for minimal frame size
Michael Niedermayer [Wed, 4 Sep 2019 13:09:09 +0000 (15:09 +0200)]
libavcodec/mpeg12dec: Check input for minimal frame size

Fixes: Timeout (35sec -> 6sec)
Fixes: 16901/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_fuzzer-5729024726269952
Fixes: 16901/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEGVIDEO_fuzzer-5642388592132096

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agotools/target_dec_fuzzer: Adjust threshold for MSS2
Michael Niedermayer [Sun, 1 Sep 2019 18:33:58 +0000 (20:33 +0200)]
tools/target_dec_fuzzer: Adjust threshold for MSS2

The decoder is slow

Fixes: Timeout (94sec -> 7sec)
Fixes: 16417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5711668050395136

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/cbs_h264: Automatically free SEI payload on error
Andreas Rheinhardt [Wed, 11 Sep 2019 22:18:29 +0000 (00:18 +0200)]
avcodec/cbs_h264: Automatically free SEI payload on error

If adding an SEI message to an access unit fails, said SEI message was
not touched, so that the caller had to free any data associated with it
that might need to be freed. But given that ff_cbs_h264_add_sei_message
can simply call cbs_h264_free_sei_payload, one can easily free
the content of the SEI payload.

This fixes a memleak when inserting a user data unregistered string for
h264_metadata fails.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
18 months agoavcodec/dxv: Check op_offset in both directions
Michael Niedermayer [Wed, 26 Jun 2019 22:29:06 +0000 (00:29 +0200)]
avcodec/dxv: Check op_offset in both directions

Fixes: signed integer overflow: 61 + 2147483647 cannot be represented in type 'int'
Fixes: 15311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5742552826773504

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/truespeech: Eliminate some left shifts
Michael Niedermayer [Fri, 20 Sep 2019 18:16:54 +0000 (20:16 +0200)]
avcodec/truespeech: Eliminate some left shifts

This avoids some invalid shifts

Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/adpcm: Check number of channels for MTAF
Michael Niedermayer [Mon, 23 Sep 2019 21:52:04 +0000 (23:52 +0200)]
avcodec/adpcm: Check number of channels for MTAF

Fixes: out of array access
Fixes: 17608/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_MTAF_fuzzer-5074936267276288

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/nvenc: fix typo in new Windows driver version
Timo Rothenpieler [Tue, 24 Sep 2019 10:00:00 +0000 (12:00 +0200)]
avcodec/nvenc: fix typo in new Windows driver version

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
18 months agoavfilter/vf_v360: do not use mod where it is not needed
Paul B Mahol [Tue, 24 Sep 2019 09:26:46 +0000 (11:26 +0200)]
avfilter/vf_v360: do not use mod where it is not needed

18 months agoavcodec/exr: cosmetics
Limin Wang [Mon, 23 Sep 2019 13:31:33 +0000 (21:31 +0800)]
avcodec/exr: cosmetics

Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/hashenc: fix incorrect use of av_mallocz_array()
Moritz Barsnick [Sun, 22 Sep 2019 12:24:11 +0000 (14:24 +0200)]
avformat/hashenc: fix incorrect use of av_mallocz_array()

Fixes CID 1453867, CID 1453866, CID 1453865.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/nvenc: add driver version info for SDK 9.1
Timo Rothenpieler [Mon, 23 Sep 2019 13:47:27 +0000 (15:47 +0200)]
avcodec/nvenc: add driver version info for SDK 9.1

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
18 months agoavcodec/bsf: check that AVBSFInternal was allocated before dereferencing it
James Almer [Mon, 23 Sep 2019 02:55:49 +0000 (23:55 -0300)]
avcodec/bsf: check that AVBSFInternal was allocated before dereferencing it

This can happen when av_bsf_free() is called on av_bsf_alloc() failure.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavfilter/vf_v360: fix regression introduced in b342678bc47b4e5
Paul B Mahol [Mon, 23 Sep 2019 10:27:41 +0000 (12:27 +0200)]
avfilter/vf_v360: fix regression introduced in b342678bc47b4e5

18 months agoavformat/dashdec: fix segfault when parsing segmentlist
vectronic [Mon, 16 Sep 2019 10:44:28 +0000 (11:44 +0100)]
avformat/dashdec: fix segfault when parsing segmentlist

index into segmentlists_tab was specified as 4 instead of 3 causing invalid access

further fix to: 8135

Reviewed-by: Steven Liu <lq@onvideo.cn>
Signed-off-by: vectronic <hello.vectronic@gmail.com>
18 months agoavformat/dashdec: fix pointer being freed was not allocated
vectronic [Mon, 16 Sep 2019 10:44:27 +0000 (11:44 +0100)]
avformat/dashdec: fix pointer being freed was not allocated

prevent attempt to call xmlFree if val was not allocated
fixes: 8135

Reviewed-by: Steven Liu <lq@onvideo.cn>
Signed-off-by: vectronic <hello.vectronic@gmail.com>
18 months agoavfilter/vf_v360: adjust h for mercator input/output
Paul B Mahol [Sun, 22 Sep 2019 20:34:13 +0000 (22:34 +0200)]
avfilter/vf_v360: adjust h for mercator input/output

18 months agoavfilter/vf_v360: fix xyz_to_mercator()
Paul B Mahol [Sun, 22 Sep 2019 20:31:07 +0000 (22:31 +0200)]
avfilter/vf_v360: fix xyz_to_mercator()

18 months agoavfilter/vf_v360: fix mercator_to_xyz()
Paul B Mahol [Sun, 22 Sep 2019 18:52:40 +0000 (20:52 +0200)]
avfilter/vf_v360: fix mercator_to_xyz()

18 months agoavfilter/v360: reduce size of some struct members
Paul B Mahol [Sun, 22 Sep 2019 17:55:31 +0000 (19:55 +0200)]
avfilter/v360: reduce size of some struct members

18 months agoavformat/y4m: do not try to seek if pts is less than 0
Paul B Mahol [Sun, 22 Sep 2019 17:24:17 +0000 (19:24 +0200)]
avformat/y4m: do not try to seek if pts is less than 0

Fixes #8193.

18 months agoavcodec/sunrast: Fix indention
Michael Niedermayer [Sat, 21 Sep 2019 16:06:24 +0000 (18:06 +0200)]
avcodec/sunrast: Fix indention

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/sunrast: Fix return type for "unsupported (compression) type"
Michael Niedermayer [Sat, 21 Sep 2019 16:06:02 +0000 (18:06 +0200)]
avcodec/sunrast: Fix return type for "unsupported (compression) type"

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavutil/opt: Fix type specifier
Andreas Rheinhardt [Sat, 21 Sep 2019 09:15:42 +0000 (11:15 +0200)]
avutil/opt: Fix type specifier

This bug has been introduced in 9e0a071e.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavfilter/vf_v360: add fixed pixel padding options
Paul B Mahol [Sun, 22 Sep 2019 12:01:14 +0000 (14:01 +0200)]
avfilter/vf_v360: add fixed pixel padding options

18 months agoavfilter/vf_v360: remove intermediate variables
Paul B Mahol [Sun, 22 Sep 2019 09:29:03 +0000 (11:29 +0200)]
avfilter/vf_v360: remove intermediate variables

18 months agotools/patcheck: remove gcc-2.95 compat check
James Zern [Fri, 20 Sep 2019 07:04:06 +0000 (00:04 -0700)]
tools/patcheck: remove gcc-2.95 compat check

this conflicts with the current contributing guidance:
http://ffmpeg.org/developer.html#Contributing
FFmpeg is programmed in the ISO C90 language with a few additional
features from ISO C99, namely:
...
for loops with variable definition (‘for (int i = 0; i < 8; i++)’);

Signed-off-by: James Zern <jzern@google.com>
18 months agoavfilter/vf_v360: fix comparison with float value
Paul B Mahol [Sat, 21 Sep 2019 19:35:39 +0000 (21:35 +0200)]
avfilter/vf_v360: fix comparison with float value

18 months agoavfilter/vf_v360: simplify xyz_to_dfisheye() calculations
Paul B Mahol [Sat, 21 Sep 2019 19:33:03 +0000 (21:33 +0200)]
avfilter/vf_v360: simplify xyz_to_dfisheye() calculations

18 months agoavfilter/vf_v360: simplify dfisheye_to_xyz() calculations
Paul B Mahol [Sat, 21 Sep 2019 19:17:37 +0000 (21:17 +0200)]
avfilter/vf_v360: simplify dfisheye_to_xyz() calculations

18 months agoavfilter/avf_showfreqs: fix check for failed allocation
Paul B Mahol [Sat, 21 Sep 2019 17:07:42 +0000 (19:07 +0200)]
avfilter/avf_showfreqs: fix check for failed allocation

18 months agoavformat/latmenc: fix context used for logging
James Almer [Sat, 21 Sep 2019 15:31:11 +0000 (12:31 -0300)]
avformat/latmenc: fix context used for logging

Signed-off-by: James Almer <jamrial@gmail.com>
18 months agoavfilter/vf_v360: simplify ball_to_xyz() calculations
Paul B Mahol [Sat, 21 Sep 2019 14:21:36 +0000 (16:21 +0200)]
avfilter/vf_v360: simplify ball_to_xyz() calculations

18 months agoavfilter/vf_v360: simplify xyz_to_ball() calculations
Paul B Mahol [Sat, 21 Sep 2019 14:07:16 +0000 (16:07 +0200)]
avfilter/vf_v360: simplify xyz_to_ball() calculations

18 months agoavfilter/vf_v360: add hammer projection
Paul B Mahol [Sat, 21 Sep 2019 13:29:18 +0000 (15:29 +0200)]
avfilter/vf_v360: add hammer projection

18 months agoavfilter/vf_v360: use lrintf() in kernel
Paul B Mahol [Sat, 21 Sep 2019 08:45:15 +0000 (10:45 +0200)]
avfilter/vf_v360: use lrintf() in kernel

18 months agoavfilter/vf_v360: fix small artifacts between corners in EAC format
Paul B Mahol [Sat, 21 Sep 2019 08:31:59 +0000 (10:31 +0200)]
avfilter/vf_v360: fix small artifacts between corners in EAC format

18 months agoavformat/hashenc: add streamhash muxer
Moritz Barsnick [Thu, 12 Sep 2019 09:23:06 +0000 (11:23 +0200)]
avformat/hashenc: add streamhash muxer

Implemented as a variant of the hash muxer, reusing most functions,
and making use of the previously introduced array of hashes.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/hashenc: use an array of hashes
Moritz Barsnick [Thu, 12 Sep 2019 09:23:05 +0000 (11:23 +0200)]
avformat/hashenc: use an array of hashes

Only the first element of the array is used currently, the other
elements are in preparation for a new muxer calculating multiple
hashes.

Also move alloc/init code from the write_header() functions to
dedicated init() functions, and the cleanup code from the
write_trailer() functions to dedicated deinit() functions.

hash_free() and framehash_free() turn out to be identical here,
but will differ in the subsequent commit, so they are not consolidated.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/hashenc: rearrange options definition
Moritz Barsnick [Thu, 12 Sep 2019 09:23:04 +0000 (11:23 +0200)]
avformat/hashenc: rearrange options definition

Only the frame* muxers support the format_version option.
Use macros to ease the proliferation of identical options to
coming muxers as well.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavutil/encryption_info: Don't pass NULL to memcpy
Andreas Rheinhardt [Wed, 18 Sep 2019 00:03:58 +0000 (02:03 +0200)]
avutil/encryption_info: Don't pass NULL to memcpy

The pointer arguments to memcpy (and several other functions of the
C standard library) are not allowed to be NULL, not even when the number
of bytes to copy is zero. An AVEncryptionInitInfo's data pointer is
explicitly allowed to be NULL and yet av_encryption_init_info_add_side_data
unconditionally used it as a source pointer to copy from. This commit changes
this so that copying is only done if the number of bytes to copy is > 0.

Fixes ticket #8141 as well as a part of ticket #8150.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Reviewed-by: Tomas Härdin <tjoppen@acc.umu.se>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agotools/target_dec_fuzzer: fuzz channels and sample_rate too
Michael Niedermayer [Fri, 20 Sep 2019 08:25:34 +0000 (10:25 +0200)]
tools/target_dec_fuzzer: fuzz channels and sample_rate too

This should increase coverage over more audio decoders.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/utils: Check channels fully earlier
Michael Niedermayer [Fri, 20 Sep 2019 08:25:05 +0000 (10:25 +0200)]
avcodec/utils: Check channels fully earlier

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/rtpenc_mpegts: copy metadata to mpegts sub-muxer
Moritz Barsnick [Mon, 2 Jul 2018 11:38:04 +0000 (13:38 +0200)]
avformat/rtpenc_mpegts: copy metadata to mpegts sub-muxer

Fixes #7293.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavformat/aiffdec: parse replaygain metadata
Moritz Barsnick [Wed, 13 Mar 2019 09:17:40 +0000 (10:17 +0100)]
avformat/aiffdec: parse replaygain metadata

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavutil/opt: Print out numeric values of option constants
Soft Works [Tue, 17 Sep 2019 01:09:05 +0000 (01:09 +0000)]
avutil/opt: Print out numeric values of option constants

It's often not obvious how option constants relate to numerical values.
Defaults are sometimes printed as numbers and from/to are always printed as numbers.
Printing the numeric values of options constants avoids this confusion.
It also allows to see which constants are equivalent.

Before this patch:

  -segment_list_type <int>        E........ set the segment list type (from -1 to 4) (default -1)
     flat                         E........ flat format
     csv                          E........ csv format
     ext                          E........ extended format
     ffconcat                     E........ ffconcat format
     m3u8                         E........ M3U8 format
     hls                          E........ Apple HTTP Live Streaming compatible

Afterwards:

  -segment_list_type <int>        E........ set the segment list type (from -1 to 4) (default -1)
     flat            0            E........ flat format
     csv             1            E........ csv format
     ext             3            E........ extended format
     ffconcat        4            E........ ffconcat format
     m3u8            2            E........ M3U8 format
     hls             2            E........ Apple HTTP Live Streaming compatible

Signed-off-by: softworkz <softworkz@hotmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavutil/opt: Fix printing integer option defaults
Soft Works [Tue, 17 Sep 2019 01:36:33 +0000 (01:36 +0000)]
avutil/opt: Fix printing integer option defaults

Integer values should not be printed using format specifier '%g' which leads to inexact display in case of higher values.

Before this patch:
  -trans_color       <int>        .D.V..... color value [...] (default 1.67772e+07)

Afterwards:
  -trans_color       <int>        .D.V..... color value [...] (default 16777215)

Signed-off-by: softworkz <softworkz@hotmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/ac3enc: Fix invalid shift
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:06 +0000 (00:17 +0200)]
avcodec/ac3enc: Fix invalid shift

Fixes the FATE-tests unknown_layout-ac3, ac3-fixed-encode, ac3-encode
and eac3-encode. It furthermore fixes the ac3-encoder bugs mentioned in
tickets #7994, #8144 and #8159.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/g723_1dec: Fix invalid shift
Andreas Rheinhardt [Thu, 19 Sep 2019 22:17:04 +0000 (00:17 +0200)]
avcodec/g723_1dec: Fix invalid shift

Fixes the FATE-tests g723_1-dec-1, g723_1-dec-2 and g723_1-dec-4.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavcodec/tdsc: Fix undefined shifts
Andreas Rheinhardt [Thu, 19 Sep 2019 22:16:59 +0000 (00:16 +0200)]
avcodec/tdsc: Fix undefined shifts

Fixes the tdsc FATE-test.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
18 months agoavfilter/vf_v360: remove uneeded array element
Paul B Mahol [Fri, 20 Sep 2019 19:41:12 +0000 (21:41 +0200)]
avfilter/vf_v360: remove uneeded array element

18 months agoavfilter/vf_v360: add support for mirroring to ball input format
Paul B Mahol [Fri, 20 Sep 2019 19:34:46 +0000 (21:34 +0200)]
avfilter/vf_v360: add support for mirroring to ball input format

18 months agoavfilter/vf_v360: adjust kernel after latest change
Paul B Mahol [Fri, 20 Sep 2019 17:14:38 +0000 (19:14 +0200)]
avfilter/vf_v360: adjust kernel after latest change

18 months agoavfilter/vf_v360: fix various artifacts with cubemaps
Paul B Mahol [Fri, 20 Sep 2019 16:14:41 +0000 (18:14 +0200)]
avfilter/vf_v360: fix various artifacts with cubemaps