ffmpeg.git
3 years agoavcodec/dirac_parser: Check that there is a previous PU before accessing it
Michael Niedermayer [Sat, 5 Dec 2015 16:15:38 +0000 (17:15 +0100)]
avcodec/dirac_parser: Check that there is a previous PU before accessing it

Fixes out of array read
Fixes: 99d142c47e6ba3510a74b872a1a2ae72/asan_heap-oob_11b36f4_3811_0f5c69e7609a88a580135678de1df844.dxa

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/dirac_parser: Add basic validity checks for next_pu_offset and prev_pu_offset
Michael Niedermayer [Sat, 5 Dec 2015 16:14:36 +0000 (17:14 +0100)]
avcodec/dirac_parser: Add basic validity checks for next_pu_offset and prev_pu_offset

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/dirac_parser: Fix potential overflows in pointer checks
Michael Niedermayer [Sat, 5 Dec 2015 16:11:54 +0000 (17:11 +0100)]
avcodec/dirac_parser: Fix potential overflows in pointer checks

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agodoc/encoders.texi: remove forgotten mention of "experimental" from libvo-aacenc
Rostislav Pehlivanov [Sat, 5 Dec 2015 16:38:18 +0000 (16:38 +0000)]
doc/encoders.texi: remove forgotten mention of "experimental" from libvo-aacenc

Previous documentation commit overlooked that particular mention.

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
3 years agoaacenc: remove the experimental flag
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:45:18 +0000 (14:45 +0000)]
aacenc: remove the experimental flag

Thiss commit removes the experimental flag from the native AAC Encoder
and thus makes it the default.

After a lot of work, done by myself and Claudio Freire, the quality of
this encoder rivals and surpasses libfdk_aac in some situations. The
encoder had instability issues earlier which prevented it from having
its experimental flag removed, however the last commits done by Claudio
removed the last known source of instability and solved a lot of
problems which were previously observed. The issues were caused by the
various coding tools interfering with the scalefactor indices. Thus,
with these problems solved, it should now be possible to declare this
encoder as the default and recommend that the users should use it
instead of others provided by external libraries, as it is both faster
and has a subjectively higher quality with selected tracks.
The encoder has still yet to be fine tuned for every possible audio file
type like music or voice, so it is hoped that with the experimental flag
removed the users should be able to provide feedback and make the
encoder better than the alternatives for every type of audio and at
every bitrate.

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
3 years agodoc/encoders.texi: update documentation for the native AAC encoder
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:43:17 +0000 (14:43 +0000)]
doc/encoders.texi: update documentation for the native AAC encoder

Since the next commit removes the experimental flag from the encoder
it's better to update the documentation which has been around in its
current form for as long as the encoder itself.

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
3 years agoaacenc: mark coders other than twoloop as experimental
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:41:41 +0000 (14:41 +0000)]
aacenc: mark coders other than twoloop as experimental

ANMR has some interesting things coming up but is currently not in a
shape fit for non-experimental usage. Same with "FAST".

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
3 years agoaacenc: mark the "faac"-like coder for removal
Rostislav Pehlivanov [Sat, 5 Dec 2015 14:38:44 +0000 (14:38 +0000)]
aacenc: mark the "faac"-like coder for removal

This coder produces a much lower quality audio than the rest, is much
slower and is unstable. Hasn't been updated for a very long time as
well, hence it is more appropriate to remove it since it also depends on
a big burden of a code (the encode_window_bands_info function which is
just as old, just as unstable and bad and in no way modifiable or
fixable).

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
3 years agoavfilter/af_stereotools: check s->length size
Paul B Mahol [Sat, 5 Dec 2015 15:08:29 +0000 (16:08 +0100)]
avfilter/af_stereotools: check s->length size

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavcodec/wmaprodec: Check bits per sample to be within the range not causing integer...
Michael Niedermayer [Sat, 5 Dec 2015 12:48:06 +0000 (13:48 +0100)]
avcodec/wmaprodec: Check bits per sample to be within the range not causing integer overflows

Fixes: 549d5aab1480d10f2a775ed90b0342f1/signal_sigabrt_7ffff6ae7cc9_5643_96bbb0cfe3e28be1dadfce1075016345.wma

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/utils: Fix overflow in get_bit_rates computations
Michael Niedermayer [Sat, 5 Dec 2015 12:15:01 +0000 (13:15 +0100)]
avcodec/utils: Fix overflow in get_bit_rates computations

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/pcm: Fix overflow in bitrate computation
Michael Niedermayer [Sat, 5 Dec 2015 12:13:10 +0000 (13:13 +0100)]
avcodec/pcm: Fix overflow in bitrate computation

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/wmaprodec: Fix overflow of cutoff
Michael Niedermayer [Sat, 5 Dec 2015 12:11:23 +0000 (13:11 +0100)]
avcodec/wmaprodec: Fix overflow of cutoff

Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/smacker: fix integer overflow with pts_inc
Michael Niedermayer [Sat, 5 Dec 2015 12:06:16 +0000 (13:06 +0100)]
avformat/smacker: fix integer overflow with pts_inc

Fixes: ce19e41f0ef1e52a23edc488faecdb58/asan_heap-oob_2504e97_4202_ffa0df1baed14022b9bfd4f8ac23d0cb.smk

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter/codecview: reindent after previous commit
Clément Bœsch [Sat, 5 Dec 2015 11:25:14 +0000 (12:25 +0100)]
avfilter/codecview: reindent after previous commit

3 years agoavfilter/codecview: add QP support
Clément Bœsch [Mon, 31 Aug 2015 13:18:34 +0000 (15:18 +0200)]
avfilter/codecview: add QP support

3 years agoMerge commit '9f57f134c19773d54269b6cb9ee455ff87c2e9e1'
Hendrik Leppkes [Sat, 5 Dec 2015 10:49:44 +0000 (11:49 +0100)]
Merge commit '9f57f134c19773d54269b6cb9ee455ff87c2e9e1'

* commit '9f57f134c19773d54269b6cb9ee455ff87c2e9e1':
  configure: ObjC support

Merged-by: Hendrik Leppkes <h.leppkes@gmail.com>
3 years agolibavformat/mov.c: allow QuickTime metadata to come after traks
Neil Birkbeck [Fri, 4 Dec 2015 00:40:24 +0000 (16:40 -0800)]
libavformat/mov.c: allow QuickTime metadata to come after traks

QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed.

Signed-off-by: Neil Birkbeck <neil.birkbeck@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoffmpeg: When streamcopying, only add the input seek position when copying timestamps.
Simon Thelen [Sun, 22 Nov 2015 14:03:17 +0000 (15:03 +0100)]
ffmpeg: When streamcopying, only add the input seek position when copying timestamps.

Using -ss as an input option shifts timestamps down by the seek, so it
doesn't have to be added to the recording time when checking whether to
stop.

Fixes #977

Signed-off-by: Simon Thelen <ffmpeg-dev@c-14.de>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoAAC encoder: ANMR, avoid empty search ranges
Claudio Freire [Sat, 5 Dec 2015 01:56:34 +0000 (22:56 -0300)]
AAC encoder: ANMR, avoid empty search ranges

Avoid generating broken paths when some bands have an
empty search space.

3 years agoaaccoder: prevent crash of anmr coder
Andreas Cadhalpun [Fri, 4 Dec 2015 17:13:07 +0000 (18:13 +0100)]
aaccoder: prevent crash of anmr coder

If minq is negative, the range of sf_idx can be larger than
SCALE_MAX_DIFF allows, causing assertion failures later in
encode_scale_factors.

Reviewed-by: Claudio Freire <klaussfreire@gmail.com>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
3 years agoswscale/utils: Fix for runtime error: left shift of negative value -1
Michael Niedermayer [Fri, 4 Dec 2015 20:44:05 +0000 (21:44 +0100)]
swscale/utils: Fix for runtime error: left shift of negative value -1

Fixes: c106b36fa36db8ff8f3ed0c82be7bea2/asan_heap-oob_32699f0_6321_467b9a1d7e03d7cfd310b7e65dc53bcc.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int
Michael Niedermayer [Fri, 4 Dec 2015 20:38:12 +0000 (21:38 +0100)]
avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int

Fixes: b293a6479bb4b5286cff24d356bfd955/asan_generic_225c3c9_7819_cc526b657450c6cdef1371b526499626.mkv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agomips: add p5600 core optimizations
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:18 +0000 (13:22 +0000)]
mips: add p5600 core optimizations

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agomips: remove --mips32r5 configure option
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:17 +0000 (13:22 +0000)]
mips: remove --mips32r5 configure option

Having a configure option with the same name as a MIPS ISA is confusing,
so better to remove it. This option was being used to add some
optimizations to a specific core (p5600). We will add the optimizations
just when the p5600 core has been detected, in a later patch.

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/flvdec: Fix left shift of 137 by 24 places cannot be represented in type int
Michael Niedermayer [Fri, 4 Dec 2015 17:53:03 +0000 (18:53 +0100)]
avformat/flvdec: Fix left shift of 137 by 24 places cannot be represented in type int

Fixes: 3c857d4d90365731524716e6d051e43a/signal_sigsegv_7f4f59bcc29e_1386_20abd2c8e655cb9c75b24368e65fe3b1.flv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/msf: Check channels when reading the header
Michael Niedermayer [Fri, 4 Dec 2015 17:48:39 +0000 (18:48 +0100)]
avformat/msf: Check channels when reading the header

Fixes integer overflow
Fixes: 0c2625f236ced104d402b4a03c0d65c7/asan_generic_274e1ce_5990_9314e7a67c26aecf011b178ade9f217c.avi

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/jpeg2000dec: Check bpno in decode_cblk()
Michael Niedermayer [Fri, 4 Dec 2015 15:23:24 +0000 (16:23 +0100)]
avcodec/jpeg2000dec: Check bpno in decode_cblk()

Fixes: undefined shift
Fixes: c409ef86f892335a0a164b5871174d5a/asan_heap-oob_1dff564_2159_162b7234616deab02b544410455eb07b.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter: add audio emphasis filter
Paul B Mahol [Mon, 30 Nov 2015 12:36:58 +0000 (13:36 +0100)]
avfilter: add audio emphasis filter

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoffmpeg: enable echoing with command and debug modes
Clément Bœsch [Thu, 19 Nov 2015 21:54:45 +0000 (22:54 +0100)]
ffmpeg: enable echoing with command and debug modes

Allow seeing text when pressing 'c' or 'd'.

3 years agoavcodec/mpegvideo: use constants for rc_strategy
Clément Bœsch [Sat, 21 Nov 2015 20:28:31 +0000 (21:28 +0100)]
avcodec/mpegvideo: use constants for rc_strategy

3 years agoswscale: use AV_OPT_TYPE_BOOL for {src,dst}_range options
Clément Bœsch [Sat, 21 Nov 2015 21:06:07 +0000 (22:06 +0100)]
swscale: use AV_OPT_TYPE_BOOL for {src,dst}_range options

3 years agoswresample: use AV_OPT_TYPE_BOOL for linear_interp and cheby options
Clément Bœsch [Sat, 21 Nov 2015 21:05:40 +0000 (22:05 +0100)]
swresample: use AV_OPT_TYPE_BOOL for linear_interp and cheby options

3 years agoavformat: use AV_OPT_TYPE_BOOL in a bunch of places
Clément Bœsch [Sat, 21 Nov 2015 21:05:07 +0000 (22:05 +0100)]
avformat: use AV_OPT_TYPE_BOOL in a bunch of places

3 years agoavfilter: use AV_OPT_TYPE_BOOL in a bunch of places
Clément Bœsch [Sat, 21 Nov 2015 21:04:54 +0000 (22:04 +0100)]
avfilter: use AV_OPT_TYPE_BOOL in a bunch of places

3 years agoavcodec: use AV_OPT_TYPE_BOOL in a bunch of places
Clément Bœsch [Sat, 21 Nov 2015 21:04:39 +0000 (22:04 +0100)]
avcodec: use AV_OPT_TYPE_BOOL in a bunch of places

3 years agoffmdec: reject zero-sized chunks
Andreas Cadhalpun [Wed, 2 Dec 2015 21:47:12 +0000 (22:47 +0100)]
ffmdec: reject zero-sized chunks

If size is zero, avio_get_str fails, leaving the buffer uninitialized.
This causes invalid reads in av_set_options_string.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
3 years agoffmdec: only seek back at EOF if a server is attached
Andreas Cadhalpun [Wed, 2 Dec 2015 21:25:55 +0000 (22:25 +0100)]
ffmdec: only seek back at EOF if a server is attached

Otherwise the ffm demuxer can return the same packets endlessly, if
there is no server attached.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
3 years agolibavcodec/aacsbr_tablegen: fix tablegen on windows
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:03 +0000 (09:52 +0100)]
libavcodec/aacsbr_tablegen: fix tablegen on windows

Including these headers is not needed and breaks building on Windows as it
tries to activate the full compat tools, which are not needed for host
tools.

3 years agoavcodec: include tablegen compat header before the tablegen functionality
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:02 +0000 (09:52 +0100)]
avcodec: include tablegen compat header before the tablegen functionality

3 years agolibavutil/tablegen: add missing math.h include
Hendrik Leppkes [Wed, 2 Dec 2015 08:52:01 +0000 (09:52 +0100)]
libavutil/tablegen: add missing math.h include

3 years agoavformat/oggparsetheora: Check duration to be not AV_NOPTS_VALUE (and positive) befor...
Michael Niedermayer [Fri, 4 Dec 2015 12:46:53 +0000 (13:46 +0100)]
avformat/oggparsetheora: Check duration to be not AV_NOPTS_VALUE (and positive) before use

Fixes: 1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_7322_4fad88a38dc8952dc20dcb60c1895758.ogg

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/dnxhddec: Fix runtime error: left shift of negative value
Michael Niedermayer [Fri, 4 Dec 2015 12:43:18 +0000 (13:43 +0100)]
avcodec/dnxhddec: Fix runtime error: left shift of negative value

Fixes: 2abd25478c62a675f335fac00b467023/asan_static-oob_10aff98_1227_8811480c6ef1e970a7977ceb7e5a9958.mxf

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoffmpeg: Check pkt_dts for AV_NOPTS_VALUE
Michael Niedermayer [Fri, 4 Dec 2015 12:17:30 +0000 (13:17 +0100)]
ffmpeg: Check pkt_dts for AV_NOPTS_VALUE

Fixes integer overflow
Fixes: 1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_2039_8d1797aeb823ea43858d0fa45c9eb899.ogv

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/vp3: Fix "runtime error: left shift of negative value"
Michael Niedermayer [Fri, 4 Dec 2015 11:47:20 +0000 (12:47 +0100)]
avcodec/vp3: Fix "runtime error: left shift of negative value"

Fixes: 5c6129154b356b80bcab86f9e3ee5d29/signal_sigabrt_7ffff6ae7cc9_7322_d26ac6d7cb6567db1b8be0159b387d0b.ogg

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/movenc: HE-AAC correct FourCC in ISML
Yann Coupin [Tue, 1 Dec 2015 11:22:38 +0000 (12:22 +0100)]
avformat/movenc: HE-AAC correct FourCC in ISML

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/mpjpegdec: Fix "libavformat/mpjpegdec.c:269:9: warning: passing argument...
Michael Niedermayer [Fri, 4 Dec 2015 02:09:00 +0000 (03:09 +0100)]
avformat/mpjpegdec: Fix "libavformat/mpjpegdec.c:269:9: warning: passing argument 3 of av_stristart from incompatible pointer type"

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agomips: rename mipsdspr1 to mipsdsp
Vicente Olivert Riera [Thu, 3 Dec 2015 13:22:16 +0000 (13:22 +0000)]
mips: rename mipsdspr1 to mipsdsp

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agompegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays
Sebastian Dröge [Thu, 3 Dec 2015 21:04:09 +0000 (23:04 +0200)]
mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays

Fixes, CID1338323, CID1338324

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/h264_direct: Check CO-POCs before use
Michael Niedermayer [Thu, 3 Dec 2015 23:31:44 +0000 (00:31 +0100)]
avcodec/h264_direct: Check CO-POCs before use

Fixes harmless integer overflow
Fixes mozilla bug 1230286

Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/utils: Fix "libavformat/utils.c:927:35: runtime error: signed integer overfl...
Michael Niedermayer [Thu, 3 Dec 2015 20:54:43 +0000 (21:54 +0100)]
avformat/utils: Fix "libavformat/utils.c:927:35: runtime error: signed integer overflow: -2450238577049583619 - 9223090561878065151 cannot be represented in type long long"

Fixes Mozilla bug 1229205

Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoaacenc_ltp: fix out of bounds memory access
Rostislav Pehlivanov [Thu, 3 Dec 2015 23:12:37 +0000 (23:12 +0000)]
aacenc_ltp: fix out of bounds memory access

Discovered by Coverity.

3 years agoavformat/riffdec: remove special case for bitrate > 32bit
Michael Niedermayer [Thu, 3 Dec 2015 19:18:35 +0000 (20:18 +0100)]
avformat/riffdec: remove special case for bitrate > 32bit

AVCodecContext.bitrate is 64bit

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/riffdec: Initialize bitrate
Michael Niedermayer [Thu, 3 Dec 2015 19:16:00 +0000 (20:16 +0100)]
avformat/riffdec: Initialize bitrate

Fixes CID1338334

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agolavf/mpegts: use AVERROR_INVALIDDATA instead of AVERROR(EINTR).
Nicolas George [Fri, 27 Nov 2015 17:58:46 +0000 (18:58 +0100)]
lavf/mpegts: use AVERROR_INVALIDDATA instead of AVERROR(EINTR).

3 years agolavf/lxfdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
Nicolas George [Fri, 27 Nov 2015 17:58:25 +0000 (18:58 +0100)]
lavf/lxfdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

3 years agolavf/mpeg: use FFERROR_REDO instead of AVERROR(EAGAIN).
Nicolas George [Fri, 27 Nov 2015 17:58:38 +0000 (18:58 +0100)]
lavf/mpeg: use FFERROR_REDO instead of AVERROR(EAGAIN).

3 years agolavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).
Nicolas George [Fri, 27 Nov 2015 17:58:05 +0000 (18:58 +0100)]
lavf/flvdec: use FFERROR_REDO instead of AVERROR(EAGAIN).

Fix trac ticket #5041.

3 years agolavf: add FFERROR_REDO to let demuxers return no packet.
Nicolas George [Fri, 27 Nov 2015 17:57:27 +0000 (18:57 +0100)]
lavf: add FFERROR_REDO to let demuxers return no packet.

3 years agompegencts: Fix overflow in cbr mode period calculations
Timo Teräs [Sat, 28 Nov 2015 06:27:39 +0000 (08:27 +0200)]
mpegencts: Fix overflow in cbr mode period calculations

ts->mux_rate is int (signed 32-bit) type. The period calculations
will start to overflow when mux_rate > 5mbps. This fixes overflows
by converting first to 64-bit type.

Fixes #5044.

Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter/af_agate: change default for detection to rms
Paul B Mahol [Thu, 3 Dec 2015 09:20:09 +0000 (10:20 +0100)]
avfilter/af_agate: change default for detection to rms

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter/af_sidechaincompress: kill init function
Paul B Mahol [Thu, 3 Dec 2015 09:05:21 +0000 (10:05 +0100)]
avfilter/af_sidechaincompress: kill init function

Should make addition of process_command easier.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter/af_agate: compile agate only when requested.
Paul B Mahol [Thu, 3 Dec 2015 09:01:50 +0000 (10:01 +0100)]
avfilter/af_agate: compile agate only when requested.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter/af_agate: add level_sc option for sidechaingate filter
Paul B Mahol [Thu, 3 Dec 2015 08:55:30 +0000 (09:55 +0100)]
avfilter/af_agate: add level_sc option for sidechaingate filter

Also correct usage of input gain for both filters.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter: add sidechaingate filter
Paul B Mahol [Sun, 29 Nov 2015 22:22:47 +0000 (23:22 +0100)]
avfilter: add sidechaingate filter

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter/af_agate: prepare for adding sidechain version
Paul B Mahol [Sun, 29 Nov 2015 22:08:22 +0000 (23:08 +0100)]
avfilter/af_agate: prepare for adding sidechain version

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agotests/api: Fix API test build on windows with --enable-shared
Hendrik Leppkes [Mon, 30 Nov 2015 21:50:12 +0000 (22:50 +0100)]
tests/api: Fix API test build on windows with --enable-shared

3 years agoavformat/mpjpegdec: fix mixed declarations and code
James Almer [Thu, 3 Dec 2015 04:39:47 +0000 (01:39 -0300)]
avformat/mpjpegdec: fix mixed declarations and code

3 years agoavutil/timecode: Fix fps check
Michael Niedermayer [Thu, 3 Dec 2015 02:14:11 +0000 (03:14 +0100)]
avutil/timecode: Fix fps check

The fps variable is explicitly set to -1 in case of some errors, the check must
thus be signed or the code setting it needs to use 0 as error code
the type of the field could be changed as well but its in an installed header

Fixes: integer overflow
Fixes: 9982cc157b1ea90429435640a989122f/asan_generic_3ad004a_3799_22cf198d9cd09928e2d9ad250474fa58.mov

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/jpeg2000: fix type of arguments of tag_tree_size
Michael Niedermayer [Thu, 3 Dec 2015 00:08:53 +0000 (01:08 +0100)]
avcodec/jpeg2000: fix type of arguments of tag_tree_size

Fixes: out of array read
Fixes: 36b8096fefab16c4c9326a508053e95c/signal_sigsegv_1d9ce18_3233_1a55196b018106dfabeace071a432d9e.r3d

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter/af_flanger: use rint instead of floor hack
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:49:22 +0000 (17:49 -0500)]
avfilter/af_flanger: use rint instead of floor hack

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavfilter/vf_perspective: use lrint instead of floor hack
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:32:15 +0000 (17:32 -0500)]
avfilter/vf_perspective: use lrint instead of floor hack

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavfilter/vsrc_mptestsrc: use lrint instead of floor hack
Ganesh Ajjanagadde [Wed, 25 Nov 2015 22:27:27 +0000 (17:27 -0500)]
avfilter/vsrc_mptestsrc: use lrint instead of floor hack

lrint is faster, and is more consistent across the codebase.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavutil/crc: avoid needless space wastage of hardcoded crc table
Ganesh Ajjanagadde [Mon, 30 Nov 2015 02:36:52 +0000 (21:36 -0500)]
avutil/crc: avoid needless space wastage of hardcoded crc table

There was no reason AFAIK for making AV_CRC_24_IEEE 12. This simply
resulted in wasted space under --enable-hardcoded-tables:
dynamic: 1318672 libavutil/libavutil.so.55
old    : 1330680 libavutil/libavutil.so.55
new    : 1326488 libavutil/libavutil.so.55

Minor version number is bumped, with ifdefry due to API breakage.

Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavcodec/vp3: ensure header is parsed successfully before tables
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avcodec/vp3: ensure header is parsed successfully before tables

Fixes assertion failure
Fixes: 266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/utils: Move end_time1 AV_NOPTS_VALUE Check after rescale
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avformat/utils: Move end_time1 AV_NOPTS_VALUE Check after rescale

Fixes integer overflow
Fixes: 266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavformat/utils: Check AVFormatContext->duration in compute_chapters_end() before use
Michael Niedermayer [Wed, 2 Dec 2015 21:59:56 +0000 (22:59 +0100)]
avformat/utils: Check AVFormatContext->duration in compute_chapters_end() before use

Fixes integer overflow
Fixes: 266ee543812e934f7b4a72923a2701d4/signal_sigabrt_7ffff6ae7cc9_7322_85218d61759d461bdf7387180e8000c9.ogg

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter/af_compand: do not clip; allow >0dB curve points
Paul B Mahol [Tue, 1 Dec 2015 19:09:08 +0000 (20:09 +0100)]
avfilter/af_compand: do not clip; allow >0dB curve points

Do not clip output samples, so that clipping can be handled by other filters.
Alow setting curve points above 0dB. This is useful when operating with floats.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavformat/mpjpeg: utilize MIME boundary value to detect start of new frame
Alex Agranovsky [Sun, 29 Nov 2015 23:54:14 +0000 (18:54 -0500)]
avformat/mpjpeg: utilize MIME boundary value to detect start of new frame

This code is disabled by default so not to regress endpoints sending invalid MIME, but can be enabled via AVOption 'strict_mime_boundary'

Signed-off-by: Alex Agranovsky <alex@sighthound.com>
3 years agoavformat/mpjpeg: allow processing of MIME parts without Content-Length header
Alex Agranovsky [Sun, 29 Nov 2015 23:36:20 +0000 (18:36 -0500)]
avformat/mpjpeg: allow processing of MIME parts without Content-Length header

Fixes ticket 5023

Signed-off-by: Alex Agranovsky <alex@sighthound.com>
3 years agoavutil/rational: Test av_rescale_rnd() with combinations of "special" values
Michael Niedermayer [Tue, 1 Dec 2015 12:34:19 +0000 (13:34 +0100)]
avutil/rational: Test av_rescale_rnd() with combinations of "special" values

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavutil/mathematics: return INT64_MIN (=AV_NOPTS_VALUE) from av_rescale_rnd() for...
Michael Niedermayer [Tue, 1 Dec 2015 12:32:31 +0000 (13:32 +0100)]
avutil/mathematics: return INT64_MIN (=AV_NOPTS_VALUE) from av_rescale_rnd() for overflows

Fixes integer overflow
Fixes: mozilla bug 1229167

Found-by: Tyson Smith
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavcodec/apedec: Check length in long_filter_high_3800()
Michael Niedermayer [Wed, 2 Dec 2015 20:16:27 +0000 (21:16 +0100)]
avcodec/apedec: Check length in long_filter_high_3800()

Fixes out of array read
Fixes: 0a7ff0c1d93da9cef28a315ec91b692a/asan_heap-oob_4a52e5_3604_9c56dbb20e308f4faeef7b35f688521a.ape

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agovp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.
Ronald S. Bultje [Tue, 1 Dec 2015 17:24:05 +0000 (12:24 -0500)]
vp9: always keep s->bytesperpixel and ctx->pix_fmt in sync.

Fixes mozilla bug 1229128.

3 years agogit-howto: mention how to clone ffmpeg-web
Andreas Cadhalpun [Tue, 24 Nov 2015 23:52:39 +0000 (00:52 +0100)]
git-howto: mention how to clone ffmpeg-web

Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
3 years agoMakefile: add cleanup of pkg-config files created by configure to distclean
Tobias Rapp [Wed, 25 Nov 2015 10:47:14 +0000 (11:47 +0100)]
Makefile: add cleanup of pkg-config files created by configure to distclean

Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
3 years agolavf/rtpenc_jpeg: Less strict check for standard Huffman tables.
Carl Eugen Hoyos [Wed, 2 Dec 2015 13:56:53 +0000 (14:56 +0100)]
lavf/rtpenc_jpeg: Less strict check for standard Huffman tables.

There can be one or more Huffman table segments DHT.

Reported-by: Andrey Utkin
3 years agoavfilter/af_stereotools: remove floor usage
Paul B Mahol [Wed, 2 Dec 2015 11:05:04 +0000 (12:05 +0100)]
avfilter/af_stereotools: remove floor usage

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoavfilter: add audio pulsator filter
Paul B Mahol [Sat, 28 Nov 2015 18:50:32 +0000 (19:50 +0100)]
avfilter: add audio pulsator filter

Signed-off-by: Paul B Mahol <onemda@gmail.com>
3 years agoAAC encoder: improve SF range utilization
Claudio Freire [Tue, 1 Dec 2015 06:28:36 +0000 (03:28 -0300)]
AAC encoder: improve SF range utilization

This patch does 4 things, all of which interact and thus it
woudln't be possible to commit them separately without causing
either quality regressions or assertion failures.

Fate comparison targets don't all reflect improvements in
quality, yet listening tests show substantially improved quality
and stability.

1. Increase SF range utilization.

The spec requires SF delta values to be constrained within the
range -60..60. The previous code was applying that range to
the whole SF array and not only the deltas of consecutive values,
because doing so requires smarter code: zeroing or otherwise
skipping a band may invalidate lots of SF choices.

This patch implements that logic to allow the coders to utilize
the full dynamic range of scalefactors, increasing quality quite
considerably, and fixing delta-SF-related assertion failures,
since now the limitation is enforced rather than asserted.

2. PNS tweaks

The previous modification makes big improvements in twoloop's
efficiency, and every time that happens PNS logic needs to be
tweaked accordingly to avoid it from stepping all over twoloop's
decisions. This patch includes modifications of the sort.

3. Account for lowpass cutoff during PSY analysis

The closer PSY's allocation is to final allocation the better
the quality is, and given these modifications, twoloop is now
very efficient at avoiding holes. Thus, to compute accurate
thresholds, PSY needs to account for the lowpass applied
implicitly during twoloop (by zeroing high bands).

This patch makes twoloop set the cutoff in psymodel's context
the first time it runs, and makes PSY account for it during
threshold computation, making PE and threshold computations
closer to the final allocation and thus achieving better
subjective quality.

4. Tweaks to RC lambda tracking loop in relation to PNS

Without this tweak some corner cases cause quality regressions.
Basically, lambda needs to react faster to overall bitrate
efficiency changes since now PNS can be quite successful in
enforcing maximum bitrates, when PSY allocates too many bits
to the lower bands, suppressing the signals RC logic uses to
lower lambda in those cases and causing aggressive PNS.

This tweak makes PNS much less aggressive, though it can still
use some further tweaks.

Also update MIPS specializations and adjust fuzz

Also in lavc/mips/aacpsy_mips.h: remove trailing whitespace

3 years agoavformat/matroskadec: Fix sample_aspect_ratio for stereo matroska content
Aaron Colwell [Mon, 23 Nov 2015 20:06:14 +0000 (12:06 -0800)]
avformat/matroskadec: Fix sample_aspect_ratio for stereo matroska content

matroskaenc.c applies divisors to the display width/height when generating
stereo content. This patch adds the corresponding multipliers to matroskadec.c
so that the original sample aspect ratio can be recovered.

Signed-off-by: wm4 <nfxjfg@googlemail.com>
3 years agoavformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.
Chris Cunningham [Tue, 1 Dec 2015 18:54:38 +0000 (10:54 -0800)]
avformat/mp3dec: prefer "fast_seek" to TOC seek for CBR files.

"Fast seek" uses linear interpolation to find the position of the
requested seek time. For CBR this is more direct than using the
mp3 TOC and bypassing the TOC avoids problems with TOC precision.
(see https://crbug.com/545914#c13)

For VBR, fast seek is not precise, so continue to prefer the TOC
when available (the lesser of two evils).

Also, some re-ordering of the logic in mp3_seek to simplify and
give usetoc=1 precedence over fastseek flag.

Signed-off-by: wm4 <nfxjfg@googlemail.com>
3 years agoavcodec/mpegaudio_tablegen: Add (), fix fate
Michael Niedermayer [Wed, 2 Dec 2015 02:42:44 +0000 (03:42 +0100)]
avcodec/mpegaudio_tablegen: Add (), fix fate

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
3 years agoavfilter/af_volumedetect: use log10 instead of hardcoded constant
Ganesh Ajjanagadde [Thu, 29 Oct 2015 04:12:53 +0000 (00:12 -0400)]
avfilter/af_volumedetect: use log10 instead of hardcoded constant

This is likely more precise and conveys the intent better.

Reviewed-by: Mark Harris <mark.hsj@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agodoc/filters/drawtext: fix centering example
Andrey Utkin [Tue, 1 Dec 2015 19:15:53 +0000 (21:15 +0200)]
doc/filters/drawtext: fix centering example

Signed-off-by: Andrey Utkin <andrey.od.utkin@gmail.com>
Signed-off-by: Lou Logan <lou@lrcd.com>
3 years agoavcodec/cbrt_tablegen: speed up dynamic table creation
Ganesh Ajjanagadde [Wed, 25 Nov 2015 21:59:07 +0000 (16:59 -0500)]
avcodec/cbrt_tablegen: speed up dynamic table creation

On systems having cbrt, there is no reason to use the slow pow function.

Sample benchmark (x86-64, Haswell, GNU/Linux):
new:
5124920 decicycles in cbrt_tableinit,       1 runs,      0 skips

old:
12321680 decicycles in cbrt_tableinit,       1 runs,      0 skips

Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavcodec/mpegaudio_tablegen: more dynamic table creation speedups
Ganesh Ajjanagadde [Sat, 28 Nov 2015 01:15:42 +0000 (20:15 -0500)]
avcodec/mpegaudio_tablegen: more dynamic table creation speedups

This further speeds up runtime initialization, with identical generated tables.

Sample benchmark (x86-64, Haswell, GNU/Linux):

old:
34441423 decicycles in mpegaudio_tableinit,    8192 runs,      0 skips

new:
10776291 decicycles in mpegaudio_tableinit,    8192 runs,      0 skips

Most low hanging fruit is taken care of here. For some idea, note that
83,064 array elements totalling 233,722 bytes need to be initialized.
Thus, with this patch, we average ~ 12.9 cycles per element or ~ 4.6
cycles per byte.

Reviewed-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavcodec/mpegaudio_tablegen: speed up dynamic table creation
Ganesh Ajjanagadde [Wed, 25 Nov 2015 21:26:08 +0000 (16:26 -0500)]
avcodec/mpegaudio_tablegen: speed up dynamic table creation

This does some miscellaneous stuff mainly avoiding the usage of pow to
achieve significant speedups. This is not speed critical, but is
unnecessary latency and cycles wasted for a user.

All tables tested and are identical to the old ones
(bit-exact even in floating point case).

Sample benchmark (x86-64, Haswell, GNU/Linux):
old:
102329530 decicycles in mpegaudio_tableinit,       1 runs,      0 skips

new:
34111900 decicycles in mpegaudio_tableinit,       1 runs,      0 skips

Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavutil/tablegen: add tablegen libm compatibility shims
Ganesh Ajjanagadde [Thu, 26 Nov 2015 14:43:52 +0000 (09:43 -0500)]
avutil/tablegen: add tablegen libm compatibility shims

This is useful for build-time table generation (--enable-hardcoded-tables),
by providing compat shims for hosts that have broken libms.

This file is deliberately kept minimal; functions can always be added on
an as-needed basis.

Reviewed-by: Clément Bœsch <u@pkh.me>
Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
3 years agoavcodec/ppc/fdctdsp: use more accurate constants
Ganesh Ajjanagadde [Fri, 13 Nov 2015 16:18:37 +0000 (11:18 -0500)]
avcodec/ppc/fdctdsp: use more accurate constants

Whoever wrote this stuff had a pretty bad libm - digits differ pretty
quickly.

Reviewed-by: Ronald S. Bultje <rsbultje@gmail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>