rtmp: fix buffer overflows in ff_amf_tag_contents()
authorXi Wang <xi.wang@gmail.com>
Wed, 23 Jan 2013 02:40:05 +0000 (21:40 -0500)
committerMichael Niedermayer <michaelni@gmx.at>
Thu, 7 Feb 2013 00:00:01 +0000 (01:00 +0100)
commitc3744b415a97e8385e866613f5da23f6146f28b6
tree77deae7a7ccd761cc8b9b3a09572841afdd8b3ef
parent7df878ac15077ccb1a4763fc285bd7e02b7b6a1f
rtmp: fix buffer overflows in ff_amf_tag_contents()

A negative `size' will bypass FFMIN().  In the subsequent memcpy() call,
`size' will be considered as a large positive value, leading to a buffer
overflow.

Change the type of `size' to unsigned int to avoid buffer overflow, and
simplify overflow checks accordingly.

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 4e692374f7962ea358c329de38c380103f8991b6)

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavformat/rtmppkt.c