avformat/vividas: Check that value from ffio_read_varlen() does not overflow
authorMichael Niedermayer <michael@niedermayer.cc>
Sat, 20 Jul 2019 20:41:08 +0000 (22:41 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Sat, 3 Aug 2019 15:44:23 +0000 (17:44 +0200)
Fixes: signed integer overflow: -1241665686 + -1340629419 cannot be represented in type 'int'
Fixes: 15922/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5692826442006528

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/vividas.c

index 1895c75..c3d3cf5 100644 (file)
@@ -374,8 +374,11 @@ static int track_header(VividasDemuxContext *viv, AVFormatContext *s,  uint8_t *
             ffio_read_varlen(pb); // len_3
             num_data = avio_r8(pb);
             for (j = 0; j < num_data; j++) {
-                data_len[j] = ffio_read_varlen(pb);
-                xd_size += data_len[j];
+                uint64_t len = ffio_read_varlen(pb);
+                if (len > INT_MAX/2 - xd_size)
+                    return AVERROR_INVALIDDATA;
+                data_len[j] = len;
+                xd_size += len;
             }
 
             st->codecpar->extradata_size = 64 + xd_size + xd_size / 255;