avutil/avstring: Fix bug and undefined behavior in av_strncasecmp()
authorMichael Niedermayer <michael@niedermayer.cc>
Mon, 15 Apr 2019 22:09:38 +0000 (00:09 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Thu, 9 May 2019 09:21:57 +0000 (11:21 +0200)
The function in case of n=0 would read more bytes than 0.
The end pointer could be beyond the allocated space, which
is undefined.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6f0e9a863466bfcbd75ee15d4d8a6aad2a5126a4)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavutil/avstring.c

index 1787a1e..ccd6446 100644 (file)
@@ -222,12 +222,13 @@ int av_strcasecmp(const char *a, const char *b)
 
 int av_strncasecmp(const char *a, const char *b, size_t n)
 {
-    const char *end = a + n;
     uint8_t c1, c2;
+    if (n <= 0)
+        return 0;
     do {
         c1 = av_tolower(*a++);
         c2 = av_tolower(*b++);
-    } while (a < end && c1 && c1 == c2);
+    } while (--n && c1 && c1 == c2);
     return c1 - c2;
 }