rtmpproto: fix out of array write
authorMichael Niedermayer <michaelni@gmx.at>
Fri, 12 Oct 2012 00:06:51 +0000 (02:06 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Fri, 12 Oct 2012 00:06:51 +0000 (02:06 +0200)
Fixes CID732263
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavformat/rtmpproto.c

index 518e7b2..d76a511 100644 (file)
@@ -1371,9 +1371,9 @@ static int rtmp_server_handshake(URLContext *s, RTMPContext *rt)
     /* By now same epoch will be sent */
     hs_my_epoch = hs_epoch;
     /* Generate random */
-    for (randomidx = 0; randomidx < (RTMP_HANDSHAKE_PACKET_SIZE);
+    for (randomidx = 8; randomidx < (RTMP_HANDSHAKE_PACKET_SIZE);
          randomidx += 4)
-        AV_WB32(hs_s1 + 8 + randomidx, av_get_random_seed());
+        AV_WB32(hs_s1 + randomidx, av_get_random_seed());
 
     ret = rtmp_send_hs_packet(rt, hs_my_epoch, 0, hs_s1,
                               RTMP_HANDSHAKE_PACKET_SIZE);