check udp_read_packet return value not to access uninitialized memory
authorEric Paul <[eric.paul@gmail.com>
Thu, 5 Jul 2007 20:58:34 +0000 (20:58 +0000)
committerBenoit Fouet <benoit.fouet@free.fr>
Thu, 5 Jul 2007 20:58:34 +0000 (20:58 +0000)
patch by Eric Paul: [eric paul gmail com]
original thread: [FFmpeg-devel] [PATCH] : libavformat segfault when a
RTSP reading is interrupted
date: 07/05/2007 03:13 PM

Originally committed as revision 9492 to svn://svn.ffmpeg.org/ffmpeg/trunk

libavformat/rtsp.c

index 3a3ffbd13d67e9f6290885c7ff33f6fb61eb2386..2607fe0409890fe38a6ec2c3df605f7d137cc432 100644 (file)
@@ -1194,7 +1194,7 @@ static int rtsp_read_packet(AVFormatContext *s,
     case RTSP_PROTOCOL_RTP_UDP:
     case RTSP_PROTOCOL_RTP_UDP_MULTICAST:
         len = udp_read_packet(s, &rtsp_st, buf, sizeof(buf));
-        if (rtsp_st->rtp_ctx)
+        if (len >=0 && rtsp_st->rtp_ctx)
             rtp_check_and_send_back_rr(rtsp_st->rtp_ctx, len);
         break;
     }