avformat/apetag: account for header size if present when returning the start position
authorJames Almer <jamrial@gmail.com>
Fri, 10 Feb 2017 04:24:27 +0000 (01:24 -0300)
committerJames Almer <jamrial@gmail.com>
Fri, 10 Feb 2017 21:33:29 +0000 (18:33 -0300)
The size field in the header/footer accounts for the entire APE tag
structure except the 32 bytes from header, for compatibility with
APEv1.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: James Almer <jamrial@gmail.com>
libavformat/apetag.c
libavformat/apetag.h

index a05b32d9e5e0a70b31d4f44047d18ae32b01ba20..b23f8cdd1ff1a8509ee1e7a379dfbd77d580ec81 100644 (file)
@@ -150,7 +150,6 @@ int64_t ff_ape_parse_tag(AVFormatContext *s)
         av_log(s, AV_LOG_ERROR, "Invalid tag size %"PRIu32".\n", tag_bytes);
         return 0;
     }
-    tag_start = file_size - tag_bytes - APE_TAG_FOOTER_BYTES;
 
     fields = avio_rl32(pb);    /* number of fields */
     if (fields > 65536) {
@@ -166,6 +165,11 @@ int64_t ff_ape_parse_tag(AVFormatContext *s)
 
     avio_seek(pb, file_size - tag_bytes, SEEK_SET);
 
+    if (val & APE_TAG_FLAG_CONTAINS_HEADER)
+        tag_bytes += APE_TAG_HEADER_BYTES;
+
+    tag_start = file_size - tag_bytes;
+
     for (i=0; i<fields; i++)
         if (ape_tag_read_field(s) < 0) break;
 
index cf2a5f8ab48b397fdc6d43142a774d163c3b36ed..49cd10eb01dfb71e5661d11aa15eb935af345f17 100644 (file)
@@ -28,6 +28,7 @@
 #define APE_TAG_PREAMBLE        "APETAGEX"
 #define APE_TAG_VERSION         2000
 #define APE_TAG_FOOTER_BYTES    32
+#define APE_TAG_HEADER_BYTES    32
 
 /**
  * Read and parse an APE tag