Pretty embarassing bug; we shouldn't use av_strlcatf() on an uninitialized

buffer, that is doomed to not work at some point.

Originally committed as revision 21368 to svn://svn.ffmpeg.org/ffmpeg/trunk

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 92416ed3cda475d3af3485b50650f6961f463efa..7d482a7edfa7961c0c7ec6317650ba470ad6715e 100644 (file)
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1589,7 +1589,7 @@ static int rtsp_read_packet(AVFormatContext *s, AVPacket *pkt)
         if (!rt->need_subscription) {
             if (memcmp (cache, rt->real_setup_cache,
                         sizeof(enum AVDiscard) * s->nb_streams)) {
         if (!rt->need_subscription) {
             if (memcmp (cache, rt->real_setup_cache,
                         sizeof(enum AVDiscard) * s->nb_streams)) {

-                av_strlcatf(cmd, sizeof(cmd),
+                snprintf(cmd, sizeof(cmd),

                             "SET_PARAMETER %s RTSP/1.0\r\n"
                             "Unsubscribe: %s\r\n",
                             s->filename, rt->last_subscription);
                             "SET_PARAMETER %s RTSP/1.0\r\n"
                             "Unsubscribe: %s\r\n",
                             s->filename, rt->last_subscription);