matroska: Fix leaking memory allocated for laces.
authorDale Curtis <dalecurtis@chromium.org>
Fri, 13 Apr 2012 00:14:35 +0000 (17:14 -0700)
committerMichael Niedermayer <michaelni@gmx.at>
Fri, 13 Apr 2012 09:43:10 +0000 (11:43 +0200)
During error conditions matroska_parse_block may exit without
freeing the memory allocated for laces.

Found via valgrind: http://pastebin.com/E54k8QFU

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
libavformat/matroskadec.c

index 6d7401b..856508c 100644 (file)
@@ -1940,6 +1940,7 @@ static int matroska_parse_block(MatroskaDemuxContext *matroska, uint8_t *data,
                         if (size < cfs * h / 2) {
                             av_log(matroska->ctx, AV_LOG_ERROR,
                                    "Corrupt int4 RM-style audio packet size\n");
+                            av_free(lace_size);
                             return AVERROR_INVALIDDATA;
                         }
                         for (x=0; x<h/2; x++)
@@ -1949,6 +1950,7 @@ static int matroska_parse_block(MatroskaDemuxContext *matroska, uint8_t *data,
                         if (size < w) {
                             av_log(matroska->ctx, AV_LOG_ERROR,
                                    "Corrupt sipr RM-style audio packet size\n");
+                            av_free(lace_size);
                             return AVERROR_INVALIDDATA;
                         }
                         memcpy(track->audio.buf + y*w, data, w);
@@ -1956,6 +1958,7 @@ static int matroska_parse_block(MatroskaDemuxContext *matroska, uint8_t *data,
                         if (size < sps * w / sps) {
                             av_log(matroska->ctx, AV_LOG_ERROR,
                                    "Corrupt generic RM-style audio packet size\n");
+                            av_free(lace_size);
                             return AVERROR_INVALIDDATA;
                         }
                         for (x=0; x<w/sps; x++)