projects
/
ffmpeg.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
86476c5
)
lavc/options: fix shallow copy context
author
Lukasz Marek
<lukasz.m.luki2@gmail.com>
Sat, 8 Nov 2014 16:01:40 +0000
(17:01 +0100)
committer
Lukasz Marek
<lukasz.m.luki2@gmail.com>
Sun, 9 Nov 2014 16:56:08 +0000
(17:56 +0100)
avcodec_copy_context leaves shallow copy of string/binary/dict options.
Double free/accessing freed memory may occur.
Signed-off-by: Lukasz Marek <lukasz.m.luki2@gmail.com>
libavcodec/options.c
patch
|
blob
|
history
diff --git
a/libavcodec/options.c
b/libavcodec/options.c
index c4ee2347665c98c2f230e0cca36f48c18937b783..461e4a13f018b5fbab1f0db2ea61d8a8dfc6adff 100644
(file)
--- a/
libavcodec/options.c
+++ b/
libavcodec/options.c
@@
-187,6
+187,7
@@
int avcodec_copy_context(AVCodecContext *dest, const AVCodecContext *src)
av_opt_free(dest);
memcpy(dest, src, sizeof(*dest));
+ av_opt_copy(dest, src);
dest->priv_data = orig_priv_data;