lavc: make avcodec_open2() fail when the timebase is not set for encoding
authorAnton Khirnov <anton@khirnov.net>
Mon, 2 May 2016 16:38:41 +0000 (18:38 +0200)
committerAnton Khirnov <anton@khirnov.net>
Mon, 16 May 2016 08:30:57 +0000 (10:30 +0200)
Many encoders use it. There is also a divide by the timebase lower in
this function, which would crash when it is not set.

libavcodec/utils.c

index d42885d..a0352b8 100644 (file)
@@ -994,6 +994,13 @@ FF_DISABLE_DEPRECATION_WARNINGS
         }
 FF_ENABLE_DEPRECATION_WARNINGS
 #endif
+
+        if (avctx->time_base.num <= 0 || avctx->time_base.den <= 0) {
+            av_log(avctx, AV_LOG_ERROR, "The encoder timebase is not set.\n");
+            ret = AVERROR(EINVAL);
+            goto free_and_end;
+        }
+
         if (avctx->codec->sample_fmts) {
             for (i = 0; avctx->codec->sample_fmts[i] != AV_SAMPLE_FMT_NONE; i++) {
                 if (avctx->sample_fmt == avctx->codec->sample_fmts[i])