Merge commit '278a923c51187d37445d88a6b21082036ec9568d'
authorMichael Niedermayer <michaelni@gmx.at>
Wed, 3 Jul 2013 11:57:59 +0000 (13:57 +0200)
committerMichael Niedermayer <michaelni@gmx.at>
Wed, 3 Jul 2013 12:19:35 +0000 (14:19 +0200)
* commit '278a923c51187d37445d88a6b21082036ec9568d':
  jpeg2000: Validate SIZ parsing

Conflicts:
libavcodec/jpeg2000dec.c

This commit is not exactly merged due to bugs in it

Merged-by: Michael Niedermayer <michaelni@gmx.at>
1  2 
libavcodec/jpeg2000dec.c

diff --combined libavcodec/jpeg2000dec.c
index b6246b6837114db7cf20f7908016d67ed62a4f85,9f7c92fe44bc734ec3555d17c0ab33a6e3c40623..e7e9a8b005e04e83b4a59186459d0135ca7b445c
@@@ -3,20 -3,20 +3,20 @@@
   * Copyright (c) 2007 Kamil Nowosad
   * Copyright (c) 2013 Nicolas Bertrand <nicoinattendu@gmail.com>
   *
 - * This file is part of Libav.
 + * This file is part of FFmpeg.
   *
 - * Libav is free software; you can redistribute it and/or
 + * FFmpeg is free software; you can redistribute it and/or
   * modify it under the terms of the GNU Lesser General Public
   * License as published by the Free Software Foundation; either
   * version 2.1 of the License, or (at your option) any later version.
   *
 - * Libav is distributed in the hope that it will be useful,
 + * FFmpeg is distributed in the hope that it will be useful,
   * but WITHOUT ANY WARRANTY; without even the implied warranty of
   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
   * Lesser General Public License for more details.
   *
   * You should have received a copy of the GNU Lesser General Public
 - * License along with Libav; if not, write to the Free Software
 + * License along with FFmpeg; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
   */
  
@@@ -25,7 -25,6 +25,7 @@@
   * JPEG 2000 image decoder
   */
  
 +#include "libavutil/avassert.h"
  #include "libavutil/common.h"
  #include "libavutil/opt.h"
  #include "avcodec.h"
@@@ -42,8 -41,9 +42,8 @@@
  #define HAD_QCC 0x02
  
  typedef struct Jpeg2000TilePart {
 -    uint16_t tp_idx;                    // Tile-part index
      uint8_t tile_index;                 // Tile index who refers the tile-part
 -    uint32_t tp_len;                    // Length of tile-part
 +    const uint8_t *tp_end;
      GetByteContext tpg;                 // bit stream in tile-part
  } Jpeg2000TilePart;
  
@@@ -54,14 -54,13 +54,14 @@@ typedef struct Jpeg2000Tile 
      uint8_t             properties[4];
      Jpeg2000CodingStyle codsty[4];
      Jpeg2000QuantStyle  qntsty[4];
 -    Jpeg2000TilePart    tile_part[3];
 +    Jpeg2000TilePart    tile_part[4];
 +    uint16_t tp_idx;                    // Tile-part index
  } Jpeg2000Tile;
  
  typedef struct Jpeg2000DecoderContext {
      AVClass         *class;
      AVCodecContext  *avctx;
 -    GetByteContext g;
 +    GetByteContext  g;
  
      int             width, height;
      int             image_offset_x, image_offset_y;
@@@ -73,7 -72,7 +73,7 @@@
      int             precision;
      int             ncomponents;
      int             tile_width, tile_height;
-     int             numXtiles, numYtiles;
+     unsigned        numXtiles, numYtiles;
      int             maxtilelen;
  
      Jpeg2000CodingStyle codsty[4];
  
      int             bit_index;
  
 -    int16_t         curtileno;
 +    int             curtileno;
 +
      Jpeg2000Tile    *tile;
  
      /*options parameters*/
 -    int16_t         lowres;
 -    int16_t         reduction_factor;
 +    int             lowres;
 +    int             reduction_factor;
  } Jpeg2000DecoderContext;
  
  /* get_bits functions for JPEG2000 packet bitstream
@@@ -97,7 -95,6 +97,7 @@@
  static int get_bits(Jpeg2000DecoderContext *s, int n)
  {
      int res = 0;
 +
      while (--n >= 0) {
          res <<= 1;
          if (s->bit_index == 0) {
@@@ -123,9 -120,6 +123,9 @@@ static int tag_tree_decode(Jpeg2000Deco
      Jpeg2000TgtNode *stack[30];
      int sp = -1, curval = 0;
  
 +    if (!node)
 +        return AVERROR(EINVAL);
 +
      while (node && !node->vis) {
          stack[++sp] = node;
          node        = node->parent;
@@@ -176,14 -170,26 +176,25 @@@ static int get_siz(Jpeg2000DecoderConte
      s->tile_offset_y  = bytestream2_get_be32u(&s->g); // YT0Siz
      ncomponents       = bytestream2_get_be16u(&s->g); // CSiz
  
-     if (ncomponents <= 0 || ncomponents > 4) {
-         av_log(s->avctx, AV_LOG_ERROR, "unsupported/invalid ncomponents: %d\n", ncomponents);
+     if (ncomponents <= 0) {
+         av_log(s->avctx, AV_LOG_ERROR, "Invalid number of components: %d\n",
+                s->ncomponents);
          return AVERROR_INVALIDDATA;
      }
 -    if (ncomponents > 3) {
++    if (ncomponents > 4) {
+         avpriv_request_sample(s->avctx, "Support for %d components",
+                               s->ncomponents);
+         return AVERROR_PATCHWELCOME;
+     }
      s->ncomponents = ncomponents;
  
-     if (s->tile_width<=0 || s->tile_height<=0)
 -    if (s->tile_width <= 0 || s->tile_height <= 0 ||
 -        s->tile_width > s->width || s->tile_height > s->height) {
++    if (s->tile_width <= 0 || s->tile_height <= 0) {
+         av_log(s->avctx, AV_LOG_ERROR, "Invalid tile dimension %dx%d.\n",
+                s->tile_width, s->tile_height);
          return AVERROR_INVALIDDATA;
+     }
  
      if (bytestream2_get_bytes_left(&s->g) < 3 * s->ncomponents)
          return AVERROR_INVALIDDATA;
          uint8_t x    = bytestream2_get_byteu(&s->g);
          s->cbps[i]   = (x & 0x7f) + 1;
          s->precision = FFMAX(s->cbps[i], s->precision);
 -        s->sgnd[i]   = (x & 0x80) == 1;
 +        s->sgnd[i]   = !!(x & 0x80);
          s->cdx[i]    = bytestream2_get_byteu(&s->g);
          s->cdy[i]    = bytestream2_get_byteu(&s->g);
 -
          if (s->cdx[i] != 1 || s->cdy[i] != 1) {
-             av_log(s->avctx, AV_LOG_ERROR, "unsupported/ CDxy values %d %d for component %d\n", s->cdx[i], s->cdy[i], i);
+             avpriv_request_sample(s->avctx,
+                                   "CDxy values %d %d for component %d",
+                                   s->cdx[i], s->cdy[i], i);
              if (!s->cdx[i] || !s->cdy[i])
                  return AVERROR_INVALIDDATA;
 -            else
 -                return AVERROR_PATCHWELCOME;
          }
      }
  
      s->numXtiles = ff_jpeg2000_ceildiv(s->width  - s->tile_offset_x, s->tile_width);
      s->numYtiles = ff_jpeg2000_ceildiv(s->height - s->tile_offset_y, s->tile_height);
  
-     if (s->numXtiles * (uint64_t)s->numYtiles > INT_MAX/sizeof(Jpeg2000Tile))
++    if (s->numXtiles * (uint64_t)s->numYtiles > INT_MAX/sizeof(*s->tile)) {
++        s->numXtiles = s->numYtiles = 0;
 +        return AVERROR(EINVAL);
++    }
 +
-     s->tile = av_mallocz(s->numXtiles * s->numYtiles * sizeof(*s->tile));
-     if (!s->tile)
+     s->tile = av_mallocz_array(s->numXtiles * s->numYtiles, sizeof(*s->tile));
+     if (!s->tile) {
+         s->numXtiles = s->numYtiles = 0;
          return AVERROR(ENOMEM);
+     }
  
      for (i = 0; i < s->numXtiles * s->numYtiles; i++) {
          Jpeg2000Tile *tile = s->tile + i;
      s->avctx->height = ff_jpeg2000_ceildivpow2(s->height - s->image_offset_y,
                                                 s->reduction_factor);
  
 -    switch (s->avctx->profile) {
 -    case FF_PROFILE_JPEG2000_DCINEMA_2K:
 -    case FF_PROFILE_JPEG2000_DCINEMA_4K:
 -        /* XYZ color-space for digital cinema profiles */
 -        s->avctx->pix_fmt = AV_PIX_FMT_XYZ12;
 +    switch(s->ncomponents) {
 +    case 1:
 +        if (s->precision > 8)
 +            s->avctx->pix_fmt = AV_PIX_FMT_GRAY16;
 +        else
 +            s->avctx->pix_fmt = AV_PIX_FMT_GRAY8;
          break;
 -    default:
 -        /* For other profiles selects color-space according number of
 -         * components and bit depth precision. */
 -        switch (s->ncomponents) {
 -        case 1:
 -            if (s->precision > 8)
 -                s->avctx->pix_fmt = AV_PIX_FMT_GRAY16;
 -            else
 -                s->avctx->pix_fmt = AV_PIX_FMT_GRAY8;
 +    case 3:
 +        switch (s->avctx->profile) {
 +        case FF_PROFILE_JPEG2000_DCINEMA_2K:
 +        case FF_PROFILE_JPEG2000_DCINEMA_4K:
 +            /* XYZ color-space for digital cinema profiles */
 +            s->avctx->pix_fmt = AV_PIX_FMT_XYZ12;
              break;
 -        case 3:
 +        default:
              if (s->precision > 8)
                  s->avctx->pix_fmt = AV_PIX_FMT_RGB48;
              else
                  s->avctx->pix_fmt = AV_PIX_FMT_RGB24;
              break;
 -        case 4:
 -            s->avctx->pix_fmt = AV_PIX_FMT_BGRA;
 -            break;
 -        default:
 -            /* pixel format can not be identified */
 -            s->avctx->pix_fmt = AV_PIX_FMT_NONE;
 -            break;
          }
          break;
 +    case 4:
 +        s->avctx->pix_fmt = AV_PIX_FMT_RGBA;
 +        break;
 +    default:
 +        /* pixel format can not be identified */
 +        s->avctx->pix_fmt = AV_PIX_FMT_NONE;
 +        break;
      }
      return 0;
  }
@@@ -270,10 -282,9 +287,10 @@@ static int get_cox(Jpeg2000DecoderConte
      /*  nreslevels = number of resolution levels
                     = number of decomposition level +1 */
      c->nreslevels = bytestream2_get_byteu(&s->g) + 1;
 -
 -    if (c->nreslevels > JPEG2000_MAX_RESLEVELS)
 +    if (c->nreslevels >= JPEG2000_MAX_RESLEVELS) {
 +        av_log(s->avctx, AV_LOG_ERROR, "nreslevels %d is invalid\n", c->nreslevels);
          return AVERROR_INVALIDDATA;
 +    }
  
      /* compute number of resolution levels to decode */
      if (c->nreslevels < s->reduction_factor)
      else
          c->nreslevels2decode = c->nreslevels - s->reduction_factor;
  
 -    c->log2_cblk_width  = bytestream2_get_byteu(&s->g) + 2; // cblk width
 -    c->log2_cblk_height = bytestream2_get_byteu(&s->g) + 2; // cblk height
 +    c->log2_cblk_width  = (bytestream2_get_byteu(&s->g) & 15) + 2; // cblk width
 +    c->log2_cblk_height = (bytestream2_get_byteu(&s->g) & 15) + 2; // cblk height
  
      if (c->log2_cblk_width > 10 || c->log2_cblk_height > 10 ||
          c->log2_cblk_width + c->log2_cblk_height > 12) {
  
      c->cblk_style = bytestream2_get_byteu(&s->g);
      if (c->cblk_style != 0) { // cblk style
 -        avpriv_request_sample(s->avctx, "Support for extra cblk styles");
 -        return AVERROR_PATCHWELCOME;
 +        av_log(s->avctx, AV_LOG_WARNING, "extra cblk styles %X\n", c->cblk_style);
      }
      c->transform = bytestream2_get_byteu(&s->g); // DWT transformation type
      /* set integer 9/7 DWT in case of BITEXACT flag */
              c->log2_prec_widths[i]  =  byte       & 0x0F;    // precinct PPx
              c->log2_prec_heights[i] = (byte >> 4) & 0x0F;    // precinct PPy
          }
 +    } else {
 +        memset(c->log2_prec_widths , 15, sizeof(c->log2_prec_widths ));
 +        memset(c->log2_prec_heights, 15, sizeof(c->log2_prec_heights));
      }
      return 0;
  }
@@@ -318,11 -327,14 +335,11 @@@ static int get_cod(Jpeg2000DecoderConte
                     uint8_t *properties)
  {
      Jpeg2000CodingStyle tmp;
 -    int compno;
 +    int compno, ret;
  
      if (bytestream2_get_bytes_left(&s->g) < 5)
          return AVERROR_INVALIDDATA;
  
 -    tmp.log2_prec_width  =
 -    tmp.log2_prec_height = 15;
 -
      tmp.csty = bytestream2_get_byteu(&s->g);
  
      // get progression order
      tmp.nlayers    = bytestream2_get_be16u(&s->g);
      tmp.mct        = bytestream2_get_byteu(&s->g); // multiple component transformation
  
 -    get_cox(s, &tmp);
 +    if (tmp.mct && s->ncomponents < 3) {
 +        av_log(s->avctx, AV_LOG_ERROR, "MCT %d with too few components (%d)\n", tmp.mct, s->ncomponents);
 +        return AVERROR_INVALIDDATA;
 +    }
 +
 +    if ((ret = get_cox(s, &tmp)) < 0)
 +        return ret;
 +
      for (compno = 0; compno < s->ncomponents; compno++)
          if (!(properties[compno] & HAD_COC))
              memcpy(c + compno, &tmp, sizeof(tmp));
  static int get_coc(Jpeg2000DecoderContext *s, Jpeg2000CodingStyle *c,
                     uint8_t *properties)
  {
 -    int compno;
 +    int compno, ret;
  
      if (bytestream2_get_bytes_left(&s->g) < 2)
          return AVERROR_INVALIDDATA;
  
      compno = bytestream2_get_byteu(&s->g);
  
 +    if (compno >= s->ncomponents) {
 +        av_log(s->avctx, AV_LOG_ERROR, "Invalid compno %d\n", compno);
 +        return AVERROR_INVALIDDATA;
 +    }
 +
      c      += compno;
      c->csty = bytestream2_get_byteu(&s->g);
 -    get_cox(s, c);
 +
 +    if ((ret = get_cox(s, c)) < 0)
 +        return ret;
  
      properties[compno] |= HAD_COC;
      return 0;
@@@ -388,7 -386,7 +405,7 @@@ static int get_qcx(Jpeg2000DecoderConte
      if (q->quantsty == JPEG2000_QSTY_NONE) {
          n -= 3;
          if (bytestream2_get_bytes_left(&s->g) < n ||
 -            n > JPEG2000_MAX_DECLEVELS)
 +            n > JPEG2000_MAX_DECLEVELS*3)
              return AVERROR_INVALIDDATA;
          for (i = 0; i < n; i++)
              q->expn[i] = bytestream2_get_byteu(&s->g) >> 3;
      } else {
          n = (n - 3) >> 1;
          if (bytestream2_get_bytes_left(&s->g) < 2 * n ||
 -            n > JPEG2000_MAX_DECLEVELS)
 +            n > JPEG2000_MAX_DECLEVELS*3)
              return AVERROR_INVALIDDATA;
          for (i = 0; i < n; i++) {
              x          = bytestream2_get_be16u(&s->g);
@@@ -443,11 -441,6 +460,11 @@@ static int get_qcc(Jpeg2000DecoderConte
          return AVERROR_INVALIDDATA;
  
      compno              = bytestream2_get_byteu(&s->g);
 +    if (compno >= s->ncomponents) {
 +        av_log(s->avctx, AV_LOG_ERROR, "Invalid compno\n");
 +        return AVERROR_INVALIDDATA;
 +    }
 +
      properties[compno] |= HAD_QCC;
      return get_qcx(s, n - 1, q + compno);
  }
@@@ -463,12 -456,14 +480,12 @@@ static int get_sot(Jpeg2000DecoderConte
      if (bytestream2_get_bytes_left(&s->g) < 8)
          return AVERROR_INVALIDDATA;
  
 +    s->curtileno = 0;
      Isot = bytestream2_get_be16u(&s->g);        // Isot
      if (Isot >= s->numXtiles * s->numYtiles)
          return AVERROR_INVALIDDATA;
  
 -    if (Isot) {
 -        avpriv_request_sample(s->avctx, "Support for more than one tile");
 -        return AVERROR_PATCHWELCOME;
 -    }
 +    s->curtileno = Isot;
      Psot  = bytestream2_get_be32u(&s->g);       // Psot
      TPsot = bytestream2_get_byteu(&s->g);       // TPsot
  
          return AVERROR_PATCHWELCOME;
      }
  
 +    s->tile[s->curtileno].tp_idx = TPsot;
      tp             = s->tile[s->curtileno].tile_part + TPsot;
      tp->tile_index = Isot;
 -    tp->tp_len     = Psot;
 -    tp->tp_idx     = TPsot;
 -
 -    /* Start of bit stream. Pointer to SOD marker
 -     * Check SOD marker is present. */
 -    if (JPEG2000_SOD == bytestream2_get_be16(&s->g)) {
 -        bytestream2_init(&tp->tpg, s->g.buffer, tp->tp_len - n - 4);
 -        bytestream2_skip(&s->g, tp->tp_len - n - 4);
 -    } else {
 -        av_log(s->avctx, AV_LOG_ERROR, "SOD marker not found \n");
 -        return AVERROR_INVALIDDATA;
 -    }
 +    tp->tp_end     = s->g.buffer + Psot - n - 2;
 +
 +    if (!TPsot) {
 +        Jpeg2000Tile *tile = s->tile + s->curtileno;
  
 -    /* End address of bit stream =
 -     *     start address + (Psot - size of SOT HEADER(n)
 -     *     - size of SOT MARKER(2)  - size of SOD marker(2) */
 +        /* copy defaults */
 +        memcpy(tile->codsty, s->codsty, s->ncomponents * sizeof(Jpeg2000CodingStyle));
 +        memcpy(tile->qntsty, s->qntsty, s->ncomponents * sizeof(Jpeg2000QuantStyle));
 +    }
  
      return 0;
  }
@@@ -549,25 -550,35 +566,25 @@@ static int init_tile(Jpeg2000DecoderCon
      int tilex = tileno % s->numXtiles;
      int tiley = tileno / s->numXtiles;
      Jpeg2000Tile *tile = s->tile + tileno;
 -    Jpeg2000CodingStyle *codsty;
 -    Jpeg2000QuantStyle  *qntsty;
  
      if (!tile->comp)
          return AVERROR(ENOMEM);
  
 -    /* copy codsty, qnsty to tile. TODO: Is it the best way?
 -     * codsty, qnsty is an array of 4 structs Jpeg2000CodingStyle
 -     * and Jpeg2000QuantStyle */
 -    memcpy(tile->codsty, s->codsty, s->ncomponents * sizeof(*codsty));
 -    memcpy(tile->qntsty, s->qntsty, s->ncomponents * sizeof(*qntsty));
 -
      for (compno = 0; compno < s->ncomponents; compno++) {
          Jpeg2000Component *comp = tile->comp + compno;
 +        Jpeg2000CodingStyle *codsty = tile->codsty + compno;
 +        Jpeg2000QuantStyle  *qntsty = tile->qntsty + compno;
          int ret; // global bandno
 -        codsty = tile->codsty + compno;
 -        qntsty = tile->qntsty + compno;
  
          comp->coord_o[0][0] = FFMAX(tilex       * s->tile_width  + s->tile_offset_x, s->image_offset_x);
          comp->coord_o[0][1] = FFMIN((tilex + 1) * s->tile_width  + s->tile_offset_x, s->width);
          comp->coord_o[1][0] = FFMAX(tiley       * s->tile_height + s->tile_offset_y, s->image_offset_y);
          comp->coord_o[1][1] = FFMIN((tiley + 1) * s->tile_height + s->tile_offset_y, s->height);
  
 -        // FIXME: add a dcinema profile check ?
 -        // value is guaranteed by profile (orig=0, 1 tile)
 -        comp->coord[0][0] = 0;
 -        comp->coord[0][1] = s->avctx->width;
 -        comp->coord[1][0] = 0;
 -        comp->coord[1][1] = s->avctx->height;
 +        comp->coord[0][0] = ff_jpeg2000_ceildivpow2(comp->coord_o[0][0], s->reduction_factor);
 +        comp->coord[0][1] = ff_jpeg2000_ceildivpow2(comp->coord_o[0][1], s->reduction_factor);
 +        comp->coord[1][0] = ff_jpeg2000_ceildivpow2(comp->coord_o[1][0], s->reduction_factor);
 +        comp->coord[1][1] = ff_jpeg2000_ceildivpow2(comp->coord_o[1][1], s->reduction_factor);
  
          if (ret = ff_jpeg2000_init_component(comp, codsty, qntsty,
                                               s->cbps[compno], s->cdx[compno],
@@@ -624,7 -635,8 +641,7 @@@ static int jpeg2000_decode_packet(Jpeg2
          if (band->coord[0][0] == band->coord[0][1] ||
              band->coord[1][0] == band->coord[1][1])
              continue;
 -        prec->yi0 = 0;
 -        prec->xi0 = 0;
 +
          nb_code_blocks =  prec->nb_codeblocks_height *
                            prec->nb_codeblocks_width;
          for (cblkno = 0; cblkno < nb_code_blocks; cblkno++) {
              else if (incl < 0)
                  return incl;
  
 -            if (!cblk->npasses)
 -                cblk->nonzerobits = expn[bandno] + numgbits - 1 -
 +            if (!cblk->npasses) {
 +                int v = expn[bandno] + numgbits - 1 -
                                      tag_tree_decode(s, prec->zerobits + cblkno,
                                                      100);
 +                if (v < 0) {
 +                    av_log(s->avctx, AV_LOG_ERROR, "nonzerobits %d invalid\n", v);
 +                    return AVERROR_INVALIDDATA;
 +                }
 +                cblk->nonzerobits = v;
 +            }
              if ((newpasses = getnpasses(s)) < 0)
                  return newpasses;
              if ((llen = getlblockinc(s)) < 0)
          nb_code_blocks = prec->nb_codeblocks_height * prec->nb_codeblocks_width;
          for (cblkno = 0; cblkno < nb_code_blocks; cblkno++) {
              Jpeg2000Cblk *cblk = prec->cblk + cblkno;
 -            if (bytestream2_get_bytes_left(&s->g) < cblk->lengthinc)
 +            if (   bytestream2_get_bytes_left(&s->g) < cblk->lengthinc
 +                || sizeof(cblk->data) < cblk->length + cblk->lengthinc + 2
 +            )
                  return AVERROR_INVALIDDATA;
 -            /* Code-block data can be empty. In that case initialize data
 -             * with 0xFFFF. */
 -            if (cblk->lengthinc > 0) {
 -                bytestream2_get_bufferu(&s->g, cblk->data, cblk->lengthinc);
 -            } else {
 -                cblk->data[0] = 0xFF;
 -                cblk->data[1] = 0xFF;
 -            }
 +
 +            bytestream2_get_bufferu(&s->g, cblk->data + cblk->length, cblk->lengthinc);
              cblk->length   += cblk->lengthinc;
              cblk->lengthinc = 0;
          }
  static int jpeg2000_decode_packets(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile)
  {
      int layno, reslevelno, compno, precno, ok_reslevel, ret;
 -    uint8_t prog_order = tile->codsty[0].prog_order;
 -    uint16_t x;
 -    uint16_t y;
 +    int x, y;
  
      s->bit_index = 8;
 -    switch (prog_order) {
 +    switch (tile->codsty[0].prog_order) {
      case JPEG2000_PGOD_LRCP:
 +    case JPEG2000_PGOD_RLCP:
          for (layno = 0; layno < tile->codsty[0].nlayers; layno++) {
              ok_reslevel = 1;
              for (reslevelno = 0; ok_reslevel; reslevelno++) {
                      Jpeg2000QuantStyle *qntsty  = tile->qntsty + compno;
                      if (reslevelno < codsty->nreslevels) {
                          Jpeg2000ResLevel *rlevel = tile->comp[compno].reslevel +
 -                                                   reslevelno;
 +                                                reslevelno;
                          ok_reslevel = 1;
                          for (precno = 0; precno < rlevel->num_precincts_x * rlevel->num_precincts_y; precno++)
                              if ((ret = jpeg2000_decode_packet(s,
  
  /* TIER-1 routines */
  static void decode_sigpass(Jpeg2000T1Context *t1, int width, int height,
 -                           int bpno, int bandno)
 +                           int bpno, int bandno, int bpass_csty_symbol,
 +                           int vert_causal_ctx_csty_symbol)
  {
      int mask = 3 << (bpno - 1), y0, x, y;
  
      for (y0 = 0; y0 < height; y0 += 4)
          for (x = 0; x < width; x++)
 -            for (y = y0; y < height && y < y0 + 4; y++)
 -                if ((t1->flags[y + 1][x + 1] & JPEG2000_T1_SIG_NB)
 -                    && !(t1->flags[y + 1][x + 1] & (JPEG2000_T1_SIG | JPEG2000_T1_VIS))) {
 -                    if (ff_mqc_decode(&t1->mqc,
 -                                      t1->mqc.cx_states +
 -                                      ff_jpeg2000_getsigctxno(t1->flags[y + 1][x + 1],
 -                                                             bandno))) {
 -                        int xorbit, ctxno = ff_jpeg2000_getsgnctxno(t1->flags[y + 1][x + 1],
 -                                                                    &xorbit);
 -
 -                        t1->data[y][x] =
 -                            (ff_mqc_decode(&t1->mqc,
 -                                           t1->mqc.cx_states + ctxno) ^ xorbit)
 -                            ? -mask : mask;
 +            for (y = y0; y < height && y < y0 + 4; y++) {
 +                if ((t1->flags[y+1][x+1] & JPEG2000_T1_SIG_NB)
 +                && !(t1->flags[y+1][x+1] & (JPEG2000_T1_SIG | JPEG2000_T1_VIS))) {
 +                    int flags_mask = -1;
 +                    if (vert_causal_ctx_csty_symbol && y == y0 + 3)
 +                        flags_mask &= ~(JPEG2000_T1_SIG_S | JPEG2000_T1_SIG_SW | JPEG2000_T1_SIG_SE);
 +                    if (ff_mqc_decode(&t1->mqc, t1->mqc.cx_states + ff_jpeg2000_getsigctxno(t1->flags[y+1][x+1] & flags_mask, bandno))) {
 +                        int xorbit, ctxno = ff_jpeg2000_getsgnctxno(t1->flags[y+1][x+1], &xorbit);
 +                        if (bpass_csty_symbol)
 +                             t1->data[y][x] = ff_mqc_decode(&t1->mqc, t1->mqc.cx_states + ctxno) ? -mask : mask;
 +                        else
 +                             t1->data[y][x] = (ff_mqc_decode(&t1->mqc, t1->mqc.cx_states + ctxno) ^ xorbit) ?
 +                                               -mask : mask;
  
                          ff_jpeg2000_set_significance(t1, x, y,
                                                       t1->data[y][x] < 0);
                      }
                      t1->flags[y + 1][x + 1] |= JPEG2000_T1_VIS;
                  }
 +            }
  }
  
  static void decode_refpass(Jpeg2000T1Context *t1, int width, int height,
  
  static void decode_clnpass(Jpeg2000DecoderContext *s, Jpeg2000T1Context *t1,
                             int width, int height, int bpno, int bandno,
 -                           int seg_symbols)
 +                           int seg_symbols, int vert_causal_ctx_csty_symbol)
  {
      int mask = 3 << (bpno - 1), y0, x, y, runlen, dec;
  
 -    for (y0 = 0; y0 < height; y0 += 4)
 +    for (y0 = 0; y0 < height; y0 += 4) {
          for (x = 0; x < width; x++) {
              if (y0 + 3 < height &&
                  !((t1->flags[y0 + 1][x + 1] & (JPEG2000_T1_SIG_NB | JPEG2000_T1_VIS | JPEG2000_T1_SIG)) ||
  
              for (y = y0 + runlen; y < y0 + 4 && y < height; y++) {
                  if (!dec) {
 -                    if (!(t1->flags[y + 1][x + 1] & (JPEG2000_T1_SIG | JPEG2000_T1_VIS)))
 -                        dec = ff_mqc_decode(&t1->mqc,
 -                                            t1->mqc.cx_states +
 -                                            ff_jpeg2000_getsigctxno(t1->flags[y + 1][x + 1],
 -                                                                   bandno));
 +                    if (!(t1->flags[y+1][x+1] & (JPEG2000_T1_SIG | JPEG2000_T1_VIS))) {
 +                        int flags_mask = -1;
 +                        if (vert_causal_ctx_csty_symbol && y == y0 + 3)
 +                            flags_mask &= ~(JPEG2000_T1_SIG_S | JPEG2000_T1_SIG_SW | JPEG2000_T1_SIG_SE);
 +                        dec = ff_mqc_decode(&t1->mqc, t1->mqc.cx_states + ff_jpeg2000_getsigctxno(t1->flags[y+1][x+1] & flags_mask,
 +                                                                                             bandno));
 +                    }
                  }
                  if (dec) {
                      int xorbit;
                  t1->flags[y + 1][x + 1] &= ~JPEG2000_T1_VIS;
              }
          }
 +    }
      if (seg_symbols) {
          int val;
          val = ff_mqc_decode(&t1->mqc, t1->mqc.cx_states + MQC_CX_UNI);
@@@ -901,41 -908,31 +918,41 @@@ static int decode_cblk(Jpeg2000DecoderC
                         Jpeg2000T1Context *t1, Jpeg2000Cblk *cblk,
                         int width, int height, int bandpos)
  {
 -    int passno = cblk->npasses, pass_t = 2, bpno = cblk->nonzerobits - 1, y;
 +    int passno = cblk->npasses, pass_t = 2, bpno = cblk->nonzerobits - 1, y, clnpass_cnt = 0;
 +    int bpass_csty_symbol = JPEG2000_CBLK_BYPASS & codsty->cblk_style;
 +    int vert_causal_ctx_csty_symbol = JPEG2000_CBLK_VSC & codsty->cblk_style;
  
      for (y = 0; y < height; y++)
 -        memset(t1->data[y], 0, width * sizeof(width));
 +        memset(t1->data[y], 0, width * sizeof(**t1->data));
 +
      /* If code-block contains no compressed data: nothing to do. */
      if (!cblk->length)
          return 0;
 -    for (y = 0; y < height + 2; y++)
 -        memset(t1->flags[y], 0, (width + 2) * sizeof(width));
  
 +    for (y = 0; y < height+2; y++)
 +        memset(t1->flags[y], 0, (width + 2)*sizeof(**t1->flags));
 +
 +    cblk->data[cblk->length] = 0xff;
 +    cblk->data[cblk->length+1] = 0xff;
      ff_mqc_initdec(&t1->mqc, cblk->data);
 -    cblk->data[cblk->length]     = 0xff;
 -    cblk->data[cblk->length + 1] = 0xff;
  
      while (passno--) {
 -        switch (pass_t) {
 +        switch(pass_t) {
          case 0:
 -            decode_sigpass(t1, width, height, bpno + 1, bandpos);
 +            decode_sigpass(t1, width, height, bpno + 1, bandpos,
 +                           bpass_csty_symbol && (clnpass_cnt >= 4), vert_causal_ctx_csty_symbol);
              break;
          case 1:
              decode_refpass(t1, width, height, bpno + 1);
 +            if (bpass_csty_symbol && clnpass_cnt >= 4)
 +                ff_mqc_initdec(&t1->mqc, cblk->data);
              break;
          case 2:
              decode_clnpass(s, t1, width, height, bpno + 1, bandpos,
 -                           codsty->cblk_style & JPEG2000_CBLK_SEGSYM);
 +                           codsty->cblk_style & JPEG2000_CBLK_SEGSYM, vert_causal_ctx_csty_symbol);
 +            clnpass_cnt = clnpass_cnt + 1;
 +            if (bpass_csty_symbol && clnpass_cnt >= 4)
 +                ff_mqc_initdec(&t1->mqc, cblk->data);
              break;
          }
  
@@@ -959,14 -956,14 +976,14 @@@ static void dequantization_float(int x
                                   Jpeg2000Component *comp,
                                   Jpeg2000T1Context *t1, Jpeg2000Band *band)
  {
 -    int i, j, idx;
 -    float *datap = &comp->data[(comp->coord[0][1] - comp->coord[0][0]) * y + x];
 -    for (j = 0; j < (cblk->coord[1][1] - cblk->coord[1][0]); ++j)
 -        for (i = 0; i < (cblk->coord[0][1] - cblk->coord[0][0]); ++i) {
 -            idx        = (comp->coord[0][1] - comp->coord[0][0]) * j + i;
 -            datap[idx] = (float)(t1->data[j][i]) * ((float)band->stepsize);
 -        }
 -    return;
 +    int i, j;
 +    int w = cblk->coord[0][1] - cblk->coord[0][0];
 +    for (j = 0; j < (cblk->coord[1][1] - cblk->coord[1][0]); ++j) {
 +        float *datap = &comp->f_data[(comp->coord[0][1] - comp->coord[0][0]) * (y + j) + x];
 +        int *src = t1->data[j];
 +        for (i = 0; i < w; ++i)
 +            datap[i] = src[i] * band->f_stepsize;
 +    }
  }
  
  /* Integer dequantization of a codeblock.*/
@@@ -974,14 -971,16 +991,14 @@@ static void dequantization_int(int x, i
                                 Jpeg2000Component *comp,
                                 Jpeg2000T1Context *t1, Jpeg2000Band *band)
  {
 -    int i, j, idx;
 -    int32_t *datap =
 -        (int32_t *) &comp->data[(comp->coord[0][1] - comp->coord[0][0]) * y + x];
 -    for (j = 0; j < (cblk->coord[1][1] - cblk->coord[1][0]); ++j)
 -        for (i = 0; i < (cblk->coord[0][1] - cblk->coord[0][0]); ++i) {
 -            idx        = (comp->coord[0][1] - comp->coord[0][0]) * j + i;
 -            datap[idx] =
 -                ((int32_t)(t1->data[j][i]) * ((int32_t)band->stepsize) + (1 << 15)) >> 16;
 -        }
 -    return;
 +    int i, j;
 +    int w = cblk->coord[0][1] - cblk->coord[0][0];
 +    for (j = 0; j < (cblk->coord[1][1] - cblk->coord[1][0]); ++j) {
 +        int32_t *datap = &comp->i_data[(comp->coord[0][1] - comp->coord[0][0]) * (y + j) + x];
 +        int *src = t1->data[j];
 +        for (i = 0; i < w; ++i)
 +            datap[i] = (src[i] * band->i_stepsize + (1 << 15)) >> 16;
 +    }
  }
  
  /* Inverse ICT parameters in float and integer.
@@@ -999,21 -998,21 +1016,21 @@@ static const int   i_ict_params[4] = 
      116130
  };
  
 -static int mct_decode(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile)
 +static void mct_decode(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile)
  {
      int i, csize = 1;
 -    int ret = 0;
      int32_t *src[3],  i0,  i1,  i2;
      float   *srcf[3], i0f, i1f, i2f;
  
      for (i = 0; i < 3; i++)
          if (tile->codsty[0].transform == FF_DWT97)
 -            srcf[i] = tile->comp[i].data;
 +            srcf[i] = tile->comp[i].f_data;
          else
 -            src[i] = (int32_t *)tile->comp[i].data;
 +            src [i] = tile->comp[i].i_data;
  
      for (i = 0; i < 2; i++)
          csize *= tile->comp[0].coord[i][1] - tile->comp[0].coord[i][0];
 +
      switch (tile->codsty[0].transform) {
      case FF_DWT97:
          for (i = 0; i < csize; i++) {
          }
          break;
      }
 -    return ret;
  }
  
  static int jpeg2000_decode_tile(Jpeg2000DecoderContext *s, Jpeg2000Tile *tile,
  
      uint8_t *line;
      Jpeg2000T1Context t1;
 -    /* Loop on tile components */
  
 +    /* Loop on tile components */
      for (compno = 0; compno < s->ncomponents; compno++) {
          Jpeg2000Component *comp     = tile->comp + compno;
          Jpeg2000CodingStyle *codsty = tile->codsty + compno;
 +
          /* Loop on resolution levels */
          for (reslevelno = 0; reslevelno < codsty->nreslevels2decode; reslevelno++) {
              Jpeg2000ResLevel *rlevel = comp->reslevel + reslevelno;
              /* Loop on bands */
              for (bandno = 0; bandno < rlevel->nbands; bandno++) {
 -                uint16_t nb_precincts, precno;
 +                int nb_precincts, precno;
                  Jpeg2000Band *band = rlevel->band + bandno;
                  int cblkno = 0, bandpos;
 +
                  bandpos = bandno + (reslevelno > 0);
  
 +                if (band->coord[0][0] == band->coord[0][1] || band->coord[1][0] == band->coord[1][1])
 +                    continue;
 +
                  nb_precincts = rlevel->num_precincts_x * rlevel->num_precincts_y;
                  /* Loop on precincts */
                  for (precno = 0; precno < nb_precincts; precno++) {
                          /* Manage band offsets */
                          x = cblk->coord[0][0];
                          y = cblk->coord[1][0];
 -                        if ((reslevelno > 0) && ((bandno + 1) & 1)) {
 -                            Jpeg2000ResLevel *pres = comp->reslevel + (reslevelno - 1);
 -                            x += pres->coord[0][1] - pres->coord[0][0];
 -                        }
 -                        if ((reslevelno > 0) && ((bandno + 1) & 2)) {
 -                            Jpeg2000ResLevel *pres = comp->reslevel + (reslevelno - 1);
 -                            y += pres->coord[1][1] - pres->coord[1][0];
 -                        }
  
 -                        if (s->avctx->flags & CODEC_FLAG_BITEXACT)
 -                            dequantization_int(x, y, cblk, comp, &t1, band);
 -                        else
 +                        if (codsty->transform == FF_DWT97)
                              dequantization_float(x, y, cblk, comp, &t1, band);
 +                        else
 +                            dequantization_int(x, y, cblk, comp, &t1, band);
                     } /* end cblk */
                  } /*end prec */
              } /* end band */
          } /* end reslevel */
  
          /* inverse DWT */
 -        ff_dwt_decode(&comp->dwt, comp->data);
 +        ff_dwt_decode(&comp->dwt, codsty->transform == FF_DWT97 ? (void*)comp->f_data : (void*)comp->i_data);
      } /*end comp */
  
      /* inverse MCT transformation */
      if (tile->codsty[0].mct)
          mct_decode(s, tile);
  
 -    if (s->avctx->pix_fmt == AV_PIX_FMT_BGRA) // RGBA -> BGRA
 -        FFSWAP(float *, tile->comp[0].data, tile->comp[2].data);
 -
      if (s->precision <= 8) {
          for (compno = 0; compno < s->ncomponents; compno++) {
              Jpeg2000Component *comp = tile->comp + compno;
 -            int32_t *datap = (int32_t *)comp->data;
 +            Jpeg2000CodingStyle *codsty = tile->codsty + compno;
 +            float *datap = comp->f_data;
 +            int32_t *i_datap = comp->i_data;
 +            int cbps = s->cbps[compno];
 +            int w = tile->comp[compno].coord[0][1] - s->image_offset_x;
 +
              y    = tile->comp[compno].coord[1][0] - s->image_offset_y;
              line = picture->data[0] + y * picture->linesize[0];
              for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {
                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;
                  dst = line + x * s->ncomponents + compno;
  
 -                for (; x < tile->comp[compno].coord[0][1] - s->image_offset_x; x += s->cdx[compno]) {
 -                    *datap += 1 << (s->cbps[compno] - 1);
 -                    if (*datap < 0)
 -                        *datap = 0;
 -                    else if (*datap >= (1 << s->cbps[compno]))
 -                        *datap = (1 << s->cbps[compno]) - 1;
 -                    *dst = *datap++;
 -                    dst += s->ncomponents;
 +                if (codsty->transform == FF_DWT97) {
 +                    for (; x < w; x += s->cdx[compno]) {
 +                        int val = lrintf(*datap) + (1 << (cbps - 1));
 +                        /* DC level shift and clip see ISO 15444-1:2002 G.1.2 */
 +                        val = av_clip(val, 0, (1 << cbps) - 1);
 +                        *dst = val << (8 - cbps);
 +                        datap++;
 +                        dst += s->ncomponents;
 +                    }
 +                } else {
 +                    for (; x < w; x += s->cdx[compno]) {
 +                        int val = *i_datap + (1 << (cbps - 1));
 +                        /* DC level shift and clip see ISO 15444-1:2002 G.1.2 */
 +                        val = av_clip(val, 0, (1 << cbps) - 1);
 +                        *dst = val << (8 - cbps);
 +                        i_datap++;
 +                        dst += s->ncomponents;
 +                    }
                  }
                  line += picture->linesize[0];
              }
      } else {
          for (compno = 0; compno < s->ncomponents; compno++) {
              Jpeg2000Component *comp = tile->comp + compno;
 -            float *datap = comp->data;
 -            int32_t *i_datap = (int32_t *) comp->data;
 +            Jpeg2000CodingStyle *codsty = tile->codsty + compno;
 +            float *datap = comp->f_data;
 +            int32_t *i_datap = comp->i_data;
              uint16_t *linel;
 +            int cbps = s->cbps[compno];
 +            int w = tile->comp[compno].coord[0][1] - s->image_offset_x;
  
              y     = tile->comp[compno].coord[1][0] - s->image_offset_y;
              linel = (uint16_t *)picture->data[0] + y * (picture->linesize[0] >> 1);
              for (; y < tile->comp[compno].coord[1][1] - s->image_offset_y; y += s->cdy[compno]) {
                  uint16_t *dst;
 +
                  x   = tile->comp[compno].coord[0][0] - s->image_offset_x;
                  dst = linel + (x * s->ncomponents + compno);
 -                for (; x < s->avctx->width; x += s->cdx[compno]) {
 -                    int16_t val;
 -                    /* DC level shift and clip see ISO 15444-1:2002 G.1.2 */
 -                    if (s->avctx->flags & CODEC_FLAG_BITEXACT)
 -                        val = *i_datap + (1 << (s->cbps[compno] - 1));
 -                    else
 -                        val = lrintf(*datap) + (1 << (s->cbps[compno] - 1));
 -                    val = av_clip(val, 0, (1 << s->cbps[compno]) - 1);
 -                    /* align 12 bit values in little-endian mode */
 -                    *dst = val << 4;
 -                    datap++;
 -                    i_datap++;
 -                    dst += s->ncomponents;
 +                if (codsty->transform == FF_DWT97) {
 +                    for (; x < w; x += s-> cdx[compno]) {
 +                        int  val = lrintf(*datap) + (1 << (cbps - 1));
 +                        /* DC level shift and clip see ISO 15444-1:2002 G.1.2 */
 +                        val = av_clip(val, 0, (1 << cbps) - 1);
 +                        /* align 12 bit values in little-endian mode */
 +                        *dst = val << (16 - cbps);
 +                        datap++;
 +                        dst += s->ncomponents;
 +                    }
 +                } else {
 +                    for (; x < w; x += s-> cdx[compno]) {
 +                        int val = *i_datap + (1 << (cbps - 1));
 +                        /* DC level shift and clip see ISO 15444-1:2002 G.1.2 */
 +                        val = av_clip(val, 0, (1 << cbps) - 1);
 +                        /* align 12 bit values in little-endian mode */
 +                        *dst = val << (16 - cbps);
 +                        i_datap++;
 +                        dst += s->ncomponents;
 +                    }
                  }
                  linel += picture->linesize[0] >> 1;
              }
          }
      }
 +
      return 0;
  }
  
@@@ -1211,7 -1190,6 +1228,7 @@@ static void jpeg2000_dec_cleanup(Jpeg20
          av_freep(&s->tile[tileno].comp);
      }
      av_freep(&s->tile);
 +    s->numXtiles = s->numYtiles = 0;
  }
  
  static int jpeg2000_read_main_headers(Jpeg2000DecoderContext *s)
          marker = bytestream2_get_be16u(&s->g);
          oldpos = bytestream2_tell(&s->g);
  
 +        if (marker == JPEG2000_SOD) {
 +            Jpeg2000Tile *tile;
 +            Jpeg2000TilePart *tp;
 +
 +            if (s->curtileno < 0) {
 +                av_log(s->avctx, AV_LOG_ERROR, "Missing SOT\n");
 +                return AVERROR_INVALIDDATA;
 +            }
 +
 +            tile = s->tile + s->curtileno;
 +            tp = tile->tile_part + tile->tp_idx;
 +            if (tp->tp_end < s->g.buffer) {
 +                av_log(s->avctx, AV_LOG_ERROR, "Invalid tpend\n");
 +                return AVERROR_INVALIDDATA;
 +            }
 +            bytestream2_init(&tp->tpg, s->g.buffer, tp->tp_end - s->g.buffer);
 +            bytestream2_skip(&s->g, tp->tp_end - s->g.buffer);
 +
 +            continue;
 +        }
          if (marker == JPEG2000_EOC)
              break;
  
 -        if (bytestream2_get_bytes_left(&s->g) < 2)
 +        len = bytestream2_get_be16(&s->g);
 +        if (len < 2 || bytestream2_get_bytes_left(&s->g) < len - 2)
              return AVERROR_INVALIDDATA;
 -        len = bytestream2_get_be16u(&s->g);
          switch (marker) {
          case JPEG2000_SIZ:
              ret = get_siz(s);
 +            if (!s->tile)
 +                s->numXtiles = s->numYtiles = 0;
              break;
          case JPEG2000_COC:
              ret = get_coc(s, codsty, properties);
              ret = get_qcd(s, len, qntsty, properties);
              break;
          case JPEG2000_SOT:
 -            ret = get_sot(s, len);
 +            if (!(ret = get_sot(s, len))) {
 +                av_assert1(s->curtileno >= 0);
 +                codsty = s->tile[s->curtileno].codsty;
 +                qntsty = s->tile[s->curtileno].qntsty;
 +                properties = s->tile[s->curtileno].properties;
 +            }
              break;
          case JPEG2000_COM:
              // the comment is ignored
              bytestream2_skip(&s->g, len - 2);
              break;
          }
 -        if (((bytestream2_tell(&s->g) - oldpos != len) && (marker != JPEG2000_SOT)) || ret) {
 +        if (bytestream2_tell(&s->g) - oldpos != len || ret) {
              av_log(s->avctx, AV_LOG_ERROR,
                     "error during processing marker segment %.4x\n", marker);
              return ret ? ret : -1;
  static int jpeg2000_read_bitstream_packets(Jpeg2000DecoderContext *s)
  {
      int ret = 0;
 -    Jpeg2000Tile *tile = s->tile + s->curtileno;
 +    int tileno;
  
 -    if (ret = init_tile(s, s->curtileno))
 -        return ret;
 -    if (ret = jpeg2000_decode_packets(s, tile))
 -        return ret;
 +    for (tileno = 0; tileno < s->numXtiles * s->numYtiles; tileno++) {
 +        Jpeg2000Tile *tile = s->tile + tileno;
 +
 +        if (ret = init_tile(s, tileno))
 +            return ret;
 +
 +        s->g = tile->tile_part[0].tpg;
 +        if (ret = jpeg2000_decode_packets(s, tile))
 +            return ret;
 +    }
  
      return 0;
  }
@@@ -1334,9 -1279,9 +1351,9 @@@ static int jp2_find_codestream(Jpeg2000
      uint32_t atom_size, atom;
      int found_codestream = 0, search_range = 10;
  
 -    while(!found_codestream && search_range
 -          &&
 -          bytestream2_get_bytes_left(&s->g) >= 8) {
 +    while (!found_codestream && search_range
 +           &&
 +           bytestream2_get_bytes_left(&s->g) >= 8) {
          atom_size = bytestream2_get_be32u(&s->g);
          atom      = bytestream2_get_be32u(&s->g);
          if (atom == JP2_CODESTREAM) {
@@@ -1364,15 -1309,13 +1381,15 @@@ static int jpeg2000_decode_frame(AVCode
  
      s->avctx     = avctx;
      bytestream2_init(&s->g, avpkt->data, avpkt->size);
 -    s->curtileno = 0; // TODO: only one tile in DCI JP2K. to implement for more tiles
 +    s->curtileno = -1;
  
      // reduction factor, i.e number of resolution levels to skip
      s->reduction_factor = s->lowres;
  
 -    if (bytestream2_get_bytes_left(&s->g) < 2)
 -        return AVERROR_INVALIDDATA;
 +    if (bytestream2_get_bytes_left(&s->g) < 2) {
 +        ret = AVERROR_INVALIDDATA;
 +        goto end;
 +    }
  
      // check if the image is in jp2 format
      if (bytestream2_get_bytes_left(&s->g) >= 12 &&
          if (!jp2_find_codestream(s)) {
              av_log(avctx, AV_LOG_ERROR,
                     "Could not find Jpeg2000 codestream atom.\n");
 -            return AVERROR_INVALIDDATA;
 +            ret = AVERROR_INVALIDDATA;
 +            goto end;
          }
      } else {
          bytestream2_seek(&s->g, 0, SEEK_SET);
  
      if (bytestream2_get_be16u(&s->g) != JPEG2000_SOC) {
          av_log(avctx, AV_LOG_ERROR, "SOC marker not present\n");
 -        return AVERROR_INVALIDDATA;
 +        ret = AVERROR_INVALIDDATA;
 +        goto end;
      }
      if (ret = jpeg2000_read_main_headers(s))
          goto end;
  
      /* get picture buffer */
 -    if ((ret = ff_thread_get_buffer(avctx, &frame, 0)) < 0) {
 -        av_log(avctx, AV_LOG_ERROR, "ff_thread_get_buffer() failed.\n");
 +    if ((ret = ff_thread_get_buffer(avctx, &frame, 0)) < 0)
          goto end;
 -    }
      picture->pict_type = AV_PICTURE_TYPE_I;
      picture->key_frame = 1;
  
      if (ret = jpeg2000_read_bitstream_packets(s))
          goto end;
 +
      for (tileno = 0; tileno < s->numXtiles * s->numYtiles; tileno++)
          if (ret = jpeg2000_decode_tile(s, s->tile + tileno, picture))
              goto end;
  
 +    jpeg2000_dec_cleanup(s);
 +
      *got_frame = 1;
  
      return bytestream2_tell(&s->g);
@@@ -1446,7 -1386,7 +1463,7 @@@ static const AVProfile profiles[] = 
      { FF_PROFILE_UNKNOWN },
  };
  
 -static const AVClass class = {
 +static const AVClass jpeg2000_class = {
      .class_name = "jpeg2000",
      .item_name  = av_default_item_name,
      .option     = options,
@@@ -1462,7 -1402,9 +1479,7 @@@ AVCodec ff_jpeg2000_decoder = 
      .priv_data_size   = sizeof(Jpeg2000DecoderContext),
      .init_static_data = jpeg2000_init_static_data,
      .decode           = jpeg2000_decode_frame,
 -    .priv_class       = &class,
 -    .pix_fmts         = (enum AVPixelFormat[]) { AV_PIX_FMT_XYZ12,
 -                                                 AV_PIX_FMT_GRAY8,
 -                                                 -1 },
 +    .priv_class       = &jpeg2000_class,
 +    .max_lowres       = 5,
      .profiles         = NULL_IF_CONFIG_SMALL(profiles)
  };